Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

desktop: Set LoadingState to Loaded even when window is maximized #19349

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

sleepycatcoding
Copy link
Member

Should fix #19343

This bug did not affect opening files after application startup since LoadingState is never set back to Loading again.

@sleepycatcoding sleepycatcoding added A-desktop Area: Desktop Application T-fix Type: Bug fix (in something that's supposed to work already) labels Jan 26, 2025
desktop/src/app.rs Outdated Show resolved Hide resolved
@sleepycatcoding sleepycatcoding force-pushed the fix_maximize_on_startup branch from 3cb6627 to 8d49814 Compare January 26, 2025 18:02
Copy link
Member

@kjarosh kjarosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@kjarosh kjarosh force-pushed the fix_maximize_on_startup branch from 8d49814 to 78cfef1 Compare January 27, 2025 23:08
@kjarosh kjarosh enabled auto-merge (rebase) January 27, 2025 23:08
Fixes ruffle-rs#19343

This bug did not affect opening files after application startup since LoadingState is never set back to Loading again.
@torokati44 torokati44 force-pushed the fix_maximize_on_startup branch from 78cfef1 to 44ab580 Compare January 27, 2025 23:10
@kjarosh kjarosh merged commit 1cfaead into ruffle-rs:master Jan 27, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-desktop Area: Desktop Application T-fix Type: Bug fix (in something that's supposed to work already)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Linux] "Open with Ruffle" does not work
2 participants