Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web: Fix extension not working in Safari 16 (close #10981) #19348

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thy486
Copy link

@thy486 thy486 commented Jan 26, 2025

If there are no other changes in Safari 16+, this PR will fix #10981

@thy486 thy486 force-pushed the fix-safari-extension branch from a661cf2 to e80b687 Compare January 27, 2025 16:37
@thy486 thy486 changed the title web: fix extension does not work in Safari 16 web: Fix extension does not work in Safari 16 Jan 27, 2025
@thy486 thy486 force-pushed the fix-safari-extension branch from e80b687 to 5010294 Compare January 28, 2025 00:04
@danielhjacobs danielhjacobs changed the title web: Fix extension does not work in Safari 16 web: Fix extension not working in Safari 16 Jan 28, 2025
@danielhjacobs danielhjacobs changed the title web: Fix extension not working in Safari 16 web: Fix extension not working in Safari 16 (close #10981) Jan 28, 2025
@thy486
Copy link
Author

thy486 commented Jan 29, 2025

It should be compatible with Safari 15 and earlier versions because I only added an additional way to get the ID. Safari current logic hides the content of the src field for scripts loaded by extensions, it is the root cause of the failure to get the ID,
further causes ruffle.ts to fail to send postMessage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extension does not work in Safari 16
1 participant