core: Fix copy channel operations on bitmaps #19335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjarosh
added
A-rendering
adrian17
approved these changes
Jan 27, 2025
This patch fixes the copy channel operations on bitmap data: 1. adds proper support for out of bounds writes, 2. fixes missing source bitmap translation.
This test verifies the behavior of BitmapData.copyChannel() method.
kjarosh
force-pushed
the
bitmapdata-copychannel
branch
from
b1b2ea9 to
7ab00f9
Compare
kjarosh
removed
the
waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes the copy channel operations on bitmap data: