Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update quick-xml to 0.35.0 #16774

Merged
merged 2 commits into from
Jun 30, 2024

Conversation

torokati44
Copy link
Member

@torokati44 torokati44 commented Jun 18, 2024

@torokati44
Copy link
Member Author

See also, for deduplication: Smithay/wayland-rs#736

@torokati44
Copy link
Member Author

Hmm, one of the errors is:

     HTML set:    <b>a<i>b</b>c</i>d</b>e
<    HTML get:    <P ALIGN="LEFT"><FONT FACE="Noto Sans" SIZE="6" COLOR="#000000" LETTERSPACING="0" KERNING="0"><B>a</B><B><I>bc</I></B><B>d</B></FONT></P>
<    Text get:    abcd
>    HTML get:    <P ALIGN="LEFT"><FONT FACE="Noto Sans" SIZE="6" COLOR="#000000" LETTERSPACING="0" KERNING="0"><B>a</B><B><I>bc</I></B><B>d</B>e</FONT></P>
>    Text get:    abcde
     HTML get ml: <!-- the same -->
<    Text get:    abcd
>    Text get:    abcde

@torokati44
Copy link
Member Author

torokati44 commented Jun 24, 2024

TODO: change to 0.33
EDIT: no, actually, to 0.34
EDIT: akshually, 0.35

@torokati44 torokati44 changed the title chore: Update quick-xml to 0.32.0 chore: Update quick-xml to 0.34.0 Jun 24, 2024
@torokati44
Copy link
Member Author

I just realized, just because quick-xml reports it as an error, we are free to handle it in whatever way we want... 🤦‍♂️

@danielhjacobs
Copy link
Contributor

danielhjacobs commented Jun 26, 2024

Looking at tafia/quick-xml#770 (comment), it sounds like they'd accept a PR to add a new option (maybe check_unmatched_end_tags) to bring back the old behavior. Do we want to open that PR?

@torokati44
Copy link
Member Author

There you go: tafia/quick-xml#772

@torokati44 torokati44 force-pushed the quick-xml-0.32 branch 2 times, most recently from 0787d4a to a8cbddc Compare June 29, 2024 18:40
@torokati44 torokati44 changed the title chore: Update quick-xml to 0.34.0 chore: Update quick-xml to 0.35.0 Jun 29, 2024
@torokati44 torokati44 marked this pull request as ready for review June 29, 2024 18:41
@torokati44 torokati44 added A-deps Area: Dependencies waiting-on-review Waiting on review from a Ruffle team member labels Jun 29, 2024
@Dinnerbone Dinnerbone merged commit be65fba into ruffle-rs:master Jun 30, 2024
17 checks passed
@danielhjacobs danielhjacobs removed the waiting-on-review Waiting on review from a Ruffle team member label Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-deps Area: Dependencies
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants