chore: eslint issues and size limit fixed

rudderlabs · Oct 21, 2024 · df7faf7 · df7faf7
1 parent 03b4dcb
commit df7faf7
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 31 deletions.
diff --git a/packages/analytics-js-plugins/src/iubendaConsentManager/utils.ts b/packages/analytics-js-plugins/src/iubendaConsentManager/utils.ts
@@ -4,10 +4,37 @@ import type { ILogger } from '@rudderstack/analytics-js-common/types/Logger';
 import type { ApplicationState } from '@rudderstack/analytics-js-common/types/ApplicationState';
 import type { ConsentsInfo } from '@rudderstack/analytics-js-common/types/Consent';
 import { isDefined } from '@rudderstack/analytics-js-common/utilities/checks';
-import { checks, storages, string } from '../shared-chunks/common';
-import { IUBENDA_CONSENT_COOKIE_READ_ERROR, IUBENDA_CONSENT_COOKIE_PARSE_ERROR } from './logMessages';
+import { checks, storages } from '../shared-chunks/common';
+import {
+  IUBENDA_CONSENT_COOKIE_READ_ERROR,
+  IUBENDA_CONSENT_COOKIE_PARSE_ERROR,
+} from './logMessages';
 import { IUBENDA_CONSENT_MANAGER_PLUGIN, IUBENDA_CONSENT_COOKIE_NAME_PATTERN } from './constants';
-import type { IubendaConsentData, IubendaConsentCookieData} from './types'
+import type { IubendaConsentData, IubendaConsentCookieData } from './types';
+
+const getIubendaCookieName = (logger?: ILogger): string => {
+  try {
+    // Retrieve cookies as a string and split them into an array
+    const cookies = document.cookie.split('; ');
+
+    // Find the cookie that matches the iubenda cookie pattern
+    const matchedCookie = cookies.find(cookie => {
+      const [name] = cookie.split('=');
+      return IUBENDA_CONSENT_COOKIE_NAME_PATTERN.test((name || '').trim());
+    });
+
+    if (!matchedCookie) {
+      throw new Error('Iubenda Cookie not found with the specified pattern.');
+    }
+
+    // Extract and return the cookie name
+    const [name] = matchedCookie.split('=');
+    return name || '';
+  } catch (err) {
+    logger?.error(IUBENDA_CONSENT_COOKIE_READ_ERROR(IUBENDA_CONSENT_MANAGER_PLUGIN), err);
+    return '';
+  }
+};
 
 /**
  * Gets the consent data from the Iubenda's consent cookie
@@ -21,14 +48,12 @@ const getIubendaConsentData = (
 ): IubendaConsentData | undefined => {
   let rawConsentCookieData = null;
   try {
-
     const dataStore = storeManager?.setStore({
       id: IUBENDA_CONSENT_MANAGER_PLUGIN,
       name: IUBENDA_CONSENT_MANAGER_PLUGIN,
       type: storages.COOKIE_STORAGE,
     });
     rawConsentCookieData = dataStore?.engine.getItem(getIubendaCookieName(logger));
-
   } catch (err) {
     logger?.error(IUBENDA_CONSENT_COOKIE_READ_ERROR(IUBENDA_CONSENT_MANAGER_PLUGIN), err);
     return undefined;
@@ -87,28 +112,5 @@ const updateConsentStateFromData = (
   state.consents.initialized.value = isDefined(iubendaConsentData);
   state.consents.data.value = consentData;
 };
-const getIubendaCookieName = ( logger?: ILogger ): string => {
-  try {
-    // Retrieve cookies as a string and split them into an array
-    const cookies = document.cookie.split('; ');
-
-    // Find the cookie that matches the iubenda cookie pattern
-    const matchedCookie = cookies.find(cookie => {
-      const [name] = cookie.split('=');
-      return IUBENDA_CONSENT_COOKIE_NAME_PATTERN.test((name || "").trim());
-    });
-
-    if (!matchedCookie) {
-      throw new Error('Iubenda Cookie not found with the specified pattern.');
-    }
-
-    // Extract and return the cookie name
-    const [name] = matchedCookie.split('=');
-    return name || "";
-  } catch (err) {
-    logger?.error(IUBENDA_CONSENT_COOKIE_READ_ERROR(IUBENDA_CONSENT_MANAGER_PLUGIN), err);
-    return "";
-  }
-};
 
 export { getIubendaConsentData, getConsentData, updateConsentStateFromData, getIubendaCookieName };
diff --git a/packages/analytics-js/.size-limit.mjs b/packages/analytics-js/.size-limit.mjs
@@ -59,7 +59,7 @@ export default [
     name: 'Core (Bundled) - Legacy - NPM (CJS)',
     path: 'dist/npm/legacy/bundled/cjs/index.cjs',
     import: '*',
-    limit: '48 KiB',
+    limit: '48.5 KiB',
   },
   {
     name: 'Core (Bundled) - Legacy - NPM (UMD)',
@@ -83,7 +83,7 @@ export default [
     name: 'Core (Bundled) - Modern - NPM (UMD)',
     path: 'dist/npm/modern/bundled/umd/index.js',
     import: '*',
-    limit: '39 KiB',
+    limit: '39.5 KiB',
   },
   {
     name: 'Core (Content Script) - Legacy - NPM (ESM)',
@@ -95,7 +95,7 @@ export default [
     name: 'Core (Content Script) - Legacy - NPM (CJS)',
     path: 'dist/npm/legacy/content-script/cjs/index.cjs',
     import: '*',
-    limit: '47.5 KiB',
+    limit: '48 KiB',
   },
   {
     name: 'Core (Content Script) - Legacy - NPM (UMD)',