-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: deduplication of metrics #20
Open
desusai7
wants to merge
8
commits into
master
Choose a base branch
from
feature/sdk-768-update-database-for-storing-batches
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: deduplication of metrics #20
desusai7
wants to merge
8
commits into
master
from
feature/sdk-768-update-database-for-storing-batches
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #20 +/- ##
============================
============================
☔ View full report in Codecov by Sentry. |
pallabmaiti
approved these changes
Nov 22, 2023
* feat: added batch generator to generate batches periodically * chore: updated sample app to be debuggable and added new files to the project * refactor: made changes to make BatchOperator and BatchGenerator unit-testable * test: fixed failing unit tests in DatabaseTests, MetricOperatorTests after enhancements in MetricOperator * test: added unit tests for batch generator * chore: fixed merge issues and changes as required * fix: updated snapshot generator timer to a default of 30 seconds and deleting metrics and errors only on successful batch generation * fix: minor changes * chore: extended Plugin protocol to create MetricsPlugin which contains execute * chore: changed crashreporter and snapshotgenerators from plugins to managers * test: fixed failing unit tests after changing CrashReporter, SnapshotGenerator to managers from plugins * feat: syncing batches with server (#24) * feat: added functions to get and clear batches in database * feat: added database observer to be notified about the changes to the db * chore: minor improvements in the ServiceManager * feat: added batch uploader to sync batches to metrics service * feat: added support for retrying with backoff when requests to metrics service get failed * chore: renamed batch to snapshot * chore: uploading snapshots on saving new snapshot * chore: added error handling to database observer * feat: added atomic property wrapper for synchronized across across threads * refactor: converted snapshot uploader to a manager and initialized it in snapshot generator * chore: minor changes --------- Co-authored-by: Desu Sai Venkat <[email protected]>
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update database for storing batches
take a snapshot of metrics at regular intervals as batches and assign random UUID
syncing batches with server