-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Potential fix for #456 #457
base: master
Are you sure you want to change the base?
Conversation
@rromanchuk can you please verify? Not sure why actually opening the class and including works and sending `:include` doesn't.
checking now, thanks for the quick reply @markrickert |
👍 Specs passed locally, so travis should be good. If it all works out I'll merge and publish a bugfix release. |
Also, I really appreciate the demo project that reproduces the bug.
|
@markrickert OK getting closer, it now no longer fails on string.rb but composer.rb, is this some sort of internal RM class? I don't see thing being related to BW?
|
@markrickert although, let me try with a clean repo, i don't trust rake clean, especially with the recent change in .build folder locations |
|2.1.0| Marks-MacBook-Pro-2 in ~/Documents/Rickert/BubbleWrap
± |fix-456 ✓| → find . -name "*composer*" I'm not seeing any files named "composer" in bubblewrap. I'm getting a different error in your example repos: |2.1.0| Marks-MacBook-Pro-2 in ~/Desktop/DebugFacebookSDK
± |master ✗| → r
Build ./build/iPhoneSimulator-8.3-Development
Compile /Users/mrickert/Documents/Rickert/BubbleWrap/motion/core/string.rb
Link ./build/iPhoneSimulator-8.3-Development/FacbookIntegration.app/FacbookIntegration
ld: warning: too many personality routines for compact unwind to encode
Create ./build/iPhoneSimulator-8.3-Development/FacbookIntegration.app/Info.plist
Create ./build/iPhoneSimulator-8.3-Development/FacbookIntegration.app.dSYM
Copy ./build/iPhoneSimulator-8.3-Development/FacbookIntegration.app.dSYM
Simulate ./build/iPhoneSimulator-8.3-Development/FacbookIntegration.app
(main)> Objective-C stub for message `startWithCompletionHandler:' type `@@:@?' not precompiled. Make sure you properly link with the framework or library that defines this message.
================================================================================
The application terminated. A crash report file may have been generated by the
system, use `rake crashlog' to open it. Use `rake debug=1' to restart the app
in the debugger.
================================================================================ |
@markrickert haha nice. Ok on my debug project it's building, Oh yeah, there are actually two ongoing problems with facebook right now, that was the first one. But if you got there it looks like it's working fine. |
Looks like in my debug project i'd have to define some "ghost methods" in rubymotion to make sure they're precompiled from the objective-c world. I'm assuming you've done that and know what I mean, but if not, i can point you in the right direction. |
The error you are seeing there is from an incorrect bridge support definition, but that's unrelated to this. It looks like my production project isn't working because of build cruft/cache, going to nuke everything and try again, but it's a good sign the debug project is working now. |
Cool. Let me know and I'll merge this and release version |
@markrickert i'm curious, do you have any idea where |
No clue... https://github.com/HipByte/RubyMotion/search?q=composer&type=Code&utf8=%E2%9C%93 I'm not seeing that error, so maybe it's from another cocoapod or gem? |
Ughhh, i found it ./.rvm/gems/ruby-2.0.0-p353/gems/twittermotion-0.0.2/lib/twittermotion/composer.rb |
@markrickert sent you a msg on gitter |
@markrickert ok, so it turns out it's even more general, here is a reproducible project that is distilled down |
OK, it seems to be an actual RubyMotion issue... I'll hold off on merging this for now till you hear back from HipByte. |
Looks like this may be resolved in RM 3.12. @rromanchuk can you test and see?
|
@rromanchuk can you verify that this is fixed in > RM 3.12 and I'll close this PR? |
@rromanchuk can you please verify?
Not sure why actually opening the class and including works and sending
:include
doesn't.