Build with clang instead of gcc

[bnoordhuis]

We may be hitting a compiler bug that is causing segfaults in production so see if switching compilers makes the problem go away.

[bnoordhuis]

Error: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run

Not a seamless upgrade then 🤦

[lloeki]

@bnoodrhuis You don't have to change build-libv8, just make clang available (e.g in Dockerfiles) and it'll favour clang over GCC.There are a couple of commits before that tried that.On 13 Sep 2024, at 20:22, Ben Noordhuis ***@***.***> wrote:We may be hitting a compiler bug that is causing segfaults in production so see if switching compilers makes the problem go away. You can view, comment on, or merge this pull request online at:   #61 Commit Summary 14d0459 Build with clang instead of gcc File Changes (1 file) M libexec/build-libv8 (2) Patch Links: https://github.com/rubyjs/libv8-node/pull/61.patch https://github.com/rubyjs/libv8-node/pull/61.diff —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[SamSaffron]

yeah @lloeki coaxing this to use clang is not super easy... I thing platform also insists on using GCC here:

libv8-node/libexec/platform

Lines 100 to 107 in 7249c5d

	x86_64-*linux*)
	CC='x86_64-linux-gnu-gcc'
	CXX='x86_64-linux-gnu-g++'
	CC_host='gcc'
	CXX_host='g++'
	STRIP='x86_64-linux-gnu-strip'
	configure_flags='--dest-cpu=x86_64 --cross-compiling --dest-os=linux'
	;;

We may need to edit this as well ... I changed the container now ... but looking at build log from previous commit ... no clang yet

May change these lines next

[SamSaffron]

[bnoordhuis]

We may need to edit this as well ... I changed the container now ... but looking at build log from previous commit ... no clang yet

It's curious how it uses clang++ for some things and ccache x86_64-linux-gnu-g++ for others. I'll look into it.

edit: I see you've fixed it already, nice!