Fix links for archives on a /pages/dump page #5358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
segiddins
approved these changes
Dec 23, 2024
|
@skatkov would you mind to provide only minimal change without stylistic changes? |
|
Don't mind at all. |
skatkov
force-pushed
the
dump-page-url-fix
branch
from
76f69af to
41969b6
Compare
|
@simi done. |
skatkov
changed the title
skatkov
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5358 +/- ##
==========================================
- Coverage 97.14% 94.37% -2.77%
==========================================
Files 458 458
Lines 9584 9643 +59
==========================================
- Hits 9310 9101 -209
- Misses 274 542 +268 ☔ View full report in Codecov by Sentry. |
simi
force-pushed
the
dump-page-url-fix
branch
from
41969b6 to
ca67fee
Compare
simi
force-pushed
the
dump-page-url-fix
branch
from
ca67fee to
f711534
Compare
|
Thanks @skatkov! |
|
@skatkov deployed! |
|
@simi Confirmed working on production ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pages/data is missing correct links to pg dumps. See here:
https://rubygems.org/pages/data
This fix resolves that by ensuring that href attribute is added to a element. Previously href attribute was added to span, hence why it wasn't working.
If I'm not mistaken, this issue was introduced in this PR:
#5080