Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gitignore changelog #1428

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Gitignore changelog #1428

merged 1 commit into from
Jan 15, 2025

Conversation

deivid-rodriguez
Copy link
Member

@deivid-rodriguez deivid-rodriguez commented Jan 15, 2025

What was the end-user problem that led to this PR?

The problem was changes in this file every time a new version is released.

What was your diagnosis of the problem?

My diagnosis was that this file is copied from the rubygems/rubygems repository. There's no need to keep it source controlled here.

What is your fix for the problem, implemented in this PR?

My fix is to gitignore it.

Why did you choose this fix out of the possible options?

I chose this fix because it makes it easier to work with this repo.

This file is copied from the rubygems/rubygems repo. No need to track it
here.
Copy link
Member

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, we get this information otherwise, as you stated in the PR description.

@olleolleolle olleolleolle merged commit 98318ee into master Jan 15, 2025
3 checks passed
@olleolleolle olleolleolle deleted the gitignore-changelog branch January 15, 2025 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants