Reduce distribution value totals by item category filter on distribution index page

[coalest]

Doesn't resolve any issue. Extracted from #4806

Description

Previously. when filtering distributions by item names or item categories, the column for total quantity of items in each distribution was reduced but the value column was not. (So if you have 5 items in category diapers for a given distribution, the quantity would show 5 but the value would show whatever the full value of the distribution is, not just the value of those diapers.)

This PR changes this behavior so that the value column now behaviors similar to the quantity column. The value column should now show only the value of the items of the filtered item or item category.

Type of change

• Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Updated tests to match the new behavior.

Screenshots

Note the changes in the value column in the screenshots below:

Before:

After:

[cielf]

It turns out that we've got some inconsistencies in how we are handling exports prior to this. In that we are treating filtering by items and filtering item by category differently. We need to expand this to include fixing that (much as I don't usually want any scope creep, I don't see an incremental path that makes sense).

So, with that in mind, could you, in the exports:
1/ for total values, make the filter by item work the same way as the filter by item category (i.e. it shows the number of items that match the filter),
2/ for the Total number of items, for the category filter , show the number of items in the category
3/ In both the item and item category cases, make the headers for the number of items and the total value indicate the filter (we do that for number of items for the item filter now).

This should leave us in a situation where the total number of items and the total value in the export will match the values in the index in all cases.

Thank you.

[cielf]

The above comment should be requested changes.

[coalest]

I'm a little confused by what you mean. I just pushed a commit as to what I think you meant.

Basically filtering by item or item category reduces both total number and total value of the distributions in both the index page and in the export csv. And the export csv headers include the filters

[cielf]

Looks to me like you interpreted correctly. Thanks! LGTM.