Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: docker databases #1346

Merged
merged 1 commit into from
Feb 1, 2025
Merged

Fix: docker databases #1346

merged 1 commit into from
Feb 1, 2025

Conversation

jmilljr24
Copy link
Collaborator

@jmilljr24 jmilljr24 commented Jan 25, 2025

🔗 Issue

Resolves #1334

✍️ Description

The queue and cable database's tables were not being created when initially running db:migrate. The default install of Solid Cable and Solid queue do not add a migration file. The tables are built from the schema files. Running db:migrate seems to looks for the migration files and when there is none, it overwrites the schema files and we end up with an database with no tables.

This change adds db:prepare to the entry point file which properly creates the tables and also seeds the db. I also removed asset precompile, maybe that will help with the assets issues in development?? #1317

I'd suggest nuking your database, then run docker compose build.

📷 Screenshots/Demos

@jmilljr24 jmilljr24 requested a review from kasugaijin January 25, 2025 14:08
@jasonwang7517
Copy link
Contributor

I also removed asset precompile, maybe that will help with the assets issues in development?? #1317

Big if true

@kasugaijin
Copy link
Collaborator

Nice! It looks good. I just want to test locally before approving. I should get to that this week.

Copy link
Collaborator

@kasugaijin kasugaijin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmilljr24 looking good so far! It has fixed some nagging issues I had. One being it would kill the app service if I got any 500 errors, but now that doesn't happen. It's also processing background jobs properly locally which is awesome! I was able to upload via the external form upload, for example.

I also tested adding a new image asset and it worked great. No need to recompile.

Great job!

@kasugaijin kasugaijin merged commit 62d1896 into main Feb 1, 2025
5 checks passed
@kasugaijin kasugaijin deleted the docker-db-prepare branch February 1, 2025 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get solid queue working in Docker
3 participants