Add browse species button unconditionally

[jasonwang7517]

🔗 Issue

Original issue

✍️ Description

• Changes logic for creation of Browse buttons on the root page to be programmatic based on unique species

📷 Screenshots/Demos

[jasonwang7517]

@kasugaijin I know there was a conversation on the original PR about whether we should only display the button if there are adoptable pets of that given species but I know we also added an empty state.

Thus, I kept the scope as is to just pull the unique species of all pets regardless of placement_type value but if you would like me to specify the scope to factor that in as well such that, for example, Browse Dogs only appears if there is at least one record with species: "Dog" and placement_type: "Adoptable" just let me know.

[kasugaijin]

@kasugaijin I know there was a conversation on the original PR about whether we should only display the button if there are adoptable pets of that given species but I know we also added an empty state.

Thus, I kept the scope as is to just pull the unique species of all pets regardless of placement_type value but if you would like me to specify the scope to factor that in as well such that, for example, Browse Dogs only appears if there is at least one record with species: "Dog" and placement_type: "Adoptable" just let me know.

The simplest approach is to keep as you suggest. I just wonder though, why take people to an empty page?

[jasonwang7517]

@kasugaijin I know there was a conversation on the original PR about whether we should only display the button if there are adoptable pets of that given species but I know we also added an empty state.
Thus, I kept the scope as is to just pull the unique species of all pets regardless of placement_type value but if you would like me to specify the scope to factor that in as well such that, for example, Browse Dogs only appears if there is at least one record with species: "Dog" and placement_type: "Adoptable" just let me know.

The simplest approach is to keep as you suggest. I just wonder though, why take people to an empty page?

To get their hopes of adopting their dream pet as high as we can before we shatter them mercilessly.

Alternatively, we can add some more logic in the partial to disable the button if there aren't any adoptable pets of that species. Just an initial suggestion. Or we can keep it as is, totally up to you boss.

[kasugaijin]

@kasugaijin I know there was a conversation on the original PR about whether we should only display the button if there are adoptable pets of that given species but I know we also added an empty state.
Thus, I kept the scope as is to just pull the unique species of all pets regardless of placement_type value but if you would like me to specify the scope to factor that in as well such that, for example, Browse Dogs only appears if there is at least one record with species: "Dog" and placement_type: "Adoptable" just let me know.

The simplest approach is to keep as you suggest. I just wonder though, why take people to an empty page?

To get their hopes of adopting their dream pet as high as we can before we shatter them mercilessly.

Alternatively, we can add some more logic in the partial to disable the button if there aren't any adoptable pets of that species. Just an initial suggestion. Or we can keep it as is, totally up to you boss.

Can’t we just chain two scopes together? I think we have one to get the adoptable pets, then one to get the species? Then the whole thing is controlled by one query without need for additional view logic. Does that make sense?

[jasonwang7517]

Yeah we totally could, wasn't sure if you wanted to separate the logic but I'll chain 'em together. Say no more.

[kasugaijin]

Looking good. There’s one more place we use these buttons - log in as an adopter or fosterer and in your dashboard index you will see them. Can you use this feature there as well?

also if you want to add in this PR we also need to add the logic to the top navbar dropdown that lets your browse species. In this case I think it’s just normal link to without button styling.

[jasonwang7517]

Gotchu

[kasugaijin]

It's looking good! Sorry for my back and forth on it. These last two small changes should do it for approval.

[kasugaijin]

Nice!