Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ruby 2.5 to appveyor #663

Merged
merged 1 commit into from
Dec 3, 2018

Conversation

colby-swandale
Copy link
Member

This PR is just adding Ruby 2.5 to appveyor CI. I think this was just forgotten about when it was released.

@colby-swandale
Copy link
Member Author

I've just realised that appveyor has been disconnected while you're waiting for evanphx/kpeg#37 #576 to be fixed. So feel free to close this.

@aycabta
Copy link
Member

aycabta commented Nov 11, 2018

I'll review and respond to this later, I escaped from CA fire accident right now. Please wait.

@colby-swandale
Copy link
Member Author

No rush! Hope you're safe!

@aycabta
Copy link
Member

aycabta commented Dec 1, 2018

This Pull Request will be merged after #672.

@aycabta aycabta merged commit 0a59591 into ruby:master Dec 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants