-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] New file RI.md #1100
Merged
Merged
[DOC] New file RI.md #1100
Changes from 3 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
4b96f8b
Doc for RI
BurdetteLamar 49288c7
Doc for RI
BurdetteLamar 5235b28
Doc for RI
BurdetteLamar 2ae2f7c
Doc for RI
BurdetteLamar d47eafb
Doc for RI
BurdetteLamar b5ecfb0
Doc for RI
BurdetteLamar 421f841
Doc for RI
BurdetteLamar 824a902
Doc for RI
BurdetteLamar eb15b7b
Doc for RI
BurdetteLamar a510c2d
Doc for RI
BurdetteLamar c06ca68
Doc for RI
BurdetteLamar 3b136ba
Doc for RI
BurdetteLamar ec2be8c
Doc for RI
BurdetteLamar 48806ce
Doc for RI
BurdetteLamar dc661d0
Doc for RI
BurdetteLamar f0f4969
Doc for RI
BurdetteLamar 7f892db
Doc for RI
BurdetteLamar c158532
Doc for RI
BurdetteLamar 21505b9
Doc for RI
BurdetteLamar 270c052
Change external links to markdown style
BurdetteLamar b9ecfb8
Change internal links to markdown style
BurdetteLamar 1fb22ff
Change internal links to markdown style
BurdetteLamar 54aafab
Doc for RI
BurdetteLamar d99e195
Doc for RI
BurdetteLamar f07407b
Doc for RI
BurdetteLamar f8d0bb8
Doc for RI
BurdetteLamar 3c80194
Doc for RI
BurdetteLamar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,5 +2,6 @@ History.txt | |
LICENSE.txt | ||
README.txt | ||
RI.txt | ||
RI.md | ||
lib | ||
doc |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋🏻 You identified this document's primary audience is people new to the
ri
command, and they would find this document mostly through GitHub. But, when rendering the document in GitHub, there are lots of weird and missing formatting artifacts coming through that make it challenging to read:{Ruby online documentation}[https://docs.ruby-lang.org/en/master]:
rdoc-ref
, but these are not rendered on GitHub. Does this mean the document is intended to be read throughri
? How do i do that?Perhaps it would be helpful to either commit to Markdown and it's ways of formatting, or stick with the RDoc way and continue to use
ri.rdoc
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd support committing to markdown format and will be happy to help with that conversion as I did something similar for IRB just not too long ago 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@colby-swandale, is there a way I can view this new file as it's rendered on GitHub? I'd like to see the problems there firsthand.
Also, not sure what you mean by 'commit to markdown'; the new page is
.md
-- a markdown page. Maybe some of the text has anrdoc
accent of which I'm not aware?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure! The current version is at: https://github.com/ruby/rdoc/blob/21505b91dd770e31c485205ac74ed44ef832432a/RI.md
The page is Markdown, but the document is utilising RDoc ways of doing things, particularly around links. When Github renders the document, the links are being rendered as raw text:
Links in Markdown need to be denoted with
[<text>](<link>)
instead of{<text>}[<link>]
as per the Markdown Spec