Eliminate external HTTP requests on test #2253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soutaro
reviewed
Jan 24, 2025
test/stdlib/Net_HTTP_test.rb
Outdated
| assert_send_type "(URI::Generic) -> nil", | ||
| Net::HTTP, :get_print, uri | ||
| assert_send_type "(String, String) -> nil", | ||
| Net::HTTP, :get_print, "www.ruby-lang.org", "/en" |
There was a problem hiding this comment.
Some lines look like they still connect to ruby-lang.org. Is this intentional?
There was a problem hiding this comment.
I was testing while disconnecting the PC from the network, but it seems the error was being suppressed in the rescue block.
|
@ksss This is really great improvement! 👏 👏 👏 |
And remove rescure
|
I removed the |
soutaro
approved these changes
Jan 24, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 24, 2025
Eliminate external HTTP requests on test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for a problem where the net/http test was failing.
Fixed to eliminate dependence on external site behavior and complete only on the local network.