🐛💥 Remove accidental Data#attributes method
#371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`#attributes` isn't part of the core `Data` API, and it never should've been added as a public method to our polyfill. This is a breaking API change, _but only for users on ruby 3.1._ For users on ruby 3.2+, this is _not_ a breaking change. For newer ruby versions, `Data#attributes` wasn't defined and this fixes YAML encoding. Since this only affects ruby 3.1 and this was only recently added (in v0.5.2), it's unlikely anyone has written code that uses this method. If they have, they'll need to convert it to `#to_h`.
nevans
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#attributesisn't part of the coreDataAPI, and it never should've been added as a public method to our polyfill.For ruby 3.2+, this is a bugfix:
Data#attributeswasn't defined and this PR fixes YAML encoding.For ruby 3.1, this is technically a breaking change.
Since this only affects ruby 3.1 and this was only recently added (in v0.5.2), it's unlikely anyone has written code that uses this
#attributes. If they have, they'll need to convert it to use#to_hinstead.