Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled windows-latest on GHA #359

Merged
merged 2 commits into from
Nov 30, 2024
Merged

Enabled windows-latest on GHA #359

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3481502
Enabled windows-latest on GHA
hsbt Nov 29, 2024
18cc951
Skip test_starttls_unknown_ca with Windows
hsbt Nov 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
strategy:
matrix:
ruby: ${{ fromJson(needs.ruby-versions.outputs.versions) }}
os: [ ubuntu-latest, macos-latest ]
os: [ ubuntu-latest, macos-latest, windows-latest ]
experimental: [false]
runs-on: ${{ matrix.os }}
continue-on-error: ${{ matrix.experimental }}
Expand Down
2 changes: 2 additions & 0 deletions test/net/imap/test_imap.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,8 @@ def test_imaps_post_connection_check

if defined?(OpenSSL::SSL)
def test_starttls_unknown_ca
omit "This test is not working with Windows" if RUBY_PLATFORM =~ /mswin|mingw/

imap = nil
assert_raise(OpenSSL::SSL::SSLError) do
ex = nil
Expand Down