Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Net::HTTP.put method #175

Merged
merged 1 commit into from
May 30, 2024
Merged

Add Net::HTTP.put method #175

merged 1 commit into from
May 30, 2024

Conversation

Zopolis4
Copy link
Contributor

As per title, as well as adding some missing documentation about Net::HTTP#put (and also adding documentation about the new Net::HTTP.put method)

Sanity tests pass locally:
image

Running rake test failed for me, but that seemed to be a limitation of webrick?

Not sure, which is why I am marking this PR as draft until I can find out where the fault lies.

@Zopolis4
Copy link
Contributor Author

Zopolis4 commented Apr 2, 2024

Looked into it further-- webrick, at least in the way it is used here, does not appear to support PUT.

This became evident when creating the function _test_request__PUT (akin to _test_request__POST), which failed despite using Net::HTTP::Put.new.

@Zopolis4 Zopolis4 marked this pull request as ready for review April 2, 2024 13:07
@hsbt hsbt merged commit ce895f6 into ruby:master May 30, 2024
15 checks passed
@hsbt
Copy link
Member

hsbt commented May 30, 2024

Seems useful. Thanks.

@Zopolis4 Zopolis4 deleted the betty branch May 30, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants