Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/net/http/test_https.rb - fixup session reuse tests #162

Closed
wants to merge 1 commit into from

Conversation

MSP-Greg
Copy link
Contributor

Add test_session_reuse_with_timeout test, which verifies that setting ssl_timeout will allow session reuse. Another test checks that not setting ssl_timeout works, as it uses OpenSSL's default value.

Rename test_session_reuse_but_expire to test_session_reuse_with_expired_timeout and fixup for WIndows mingw/ucrt builds.

@MSP-Greg
Copy link
Contributor Author

Duplicate of ruby/ruby#9033. Not sure which is preferred.

@rhenium
Copy link
Member

rhenium commented Nov 25, 2023

I wonder why this is failing on Windows only, as it doesn't seem to be relying on platform-dependent features.

@MSP-Greg
Copy link
Contributor Author

@rhenium

Yesterday (Thanksgiving) was not a good day for finding a block of time to work on this. It's obviously upstream of net-http.

I just noticed that MSYS2 has already jumped to OpenSSL 3.2.0. Note that the only build 'fully' using it is the urcrt build, as head is still a bit of both (see here). I suspect MSFT/vcpkg will update soon also, but it's still using 3.1.4.

I'm going to add ucrt to #163 and see if it passes...

@MSP-Greg
Copy link
Contributor Author

I ran CI in my fork of ruby/openssl, and Windows ucrt passed.

Is this covered by the tests there?

@MSP-Greg
Copy link
Contributor Author

Closing in favor of #165

@MSP-Greg MSP-Greg closed this Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants