Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Valentine Kopotchel - 2 #56

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Valentine Kopotchel - 2 #56

wants to merge 3 commits into from

Conversation

valkovik15
Copy link
Contributor

@valkovik15 valkovik15 commented Feb 28, 2019 •
edited
Loading

Name

Valentine Kopotchel

Homework#

2

Link to video with demo

https://youtu.be/XZnAYju9DWM

Comment

Level 1 and 2.and 3

Checklist

  • I have read homework assignment fully
  • I have implemented homework assignment fully
  • My pull request is named "#{name} #{surname} - #{homework_number}"
  • My code is located under "#{name} #{surname}/#{homework_number}"
  • It executes correctly
  • It doesn't crash, freeze, kill everyone on unexpected input
  • Credentials are NOT hardcoded
  • Large files and credentials added to .gitignore INSIDE homework dir
  • It can be tested in under 10 minutes (download part + parse + execute)
  • Gemfile added, it runs under bundle exec without error

houndci-bot
houndci-bot reviewed Feb 28, 2019
View reviewed changes
Copy link

@houndci-bot houndci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Error: We found some problems with your configuration file: [/IrresponsibleMo... 
Error: We found some problems with your configuration file: [/IrresponsibleModule] key 'IrresponsibleModule:' is undefined., [/DuplicateMethodCall] key 'DuplicateMethodCall:' is undefined., [/UtilityFunction] key 'UtilityFunction:' is undefined.

Valentine Kopotchel/2/Tracker/test/test_helper.rb
require_relative '../config/environment'
require 'rails/test_help'

class ActiveSupport::TestCase
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/ClassAndModuleChildren: Use nested module/class definitions instead of compact style.

Valentine Kopotchel/2/Tracker/test/system/ingestions_test.rb
click_on "Destroy", match: :first
end

assert_text "Ingestion was successfully destroyed"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

Valentine Kopotchel/2/Tracker/test/system/ingestions_test.rb
test "destroying a Ingestion" do
visit ingestions_url
page.accept_confirm do
click_on "Destroy", match: :first
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

Valentine Kopotchel/2/Tracker/test/system/ingestions_test.rb
click_on "Back"
end

test "destroying a Ingestion" do
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

Valentine Kopotchel/2/Tracker/test/system/ingestions_test.rb
click_on "Update Ingestion"

assert_text "Ingestion was successfully updated"
click_on "Back"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

Valentine Kopotchel/2/Tracker/test/system/ingestions_test.rb
click_on "Back"
end

test "updating a Ingestion" do
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

Valentine Kopotchel/2/Tracker/test/system/ingestions_test.rb
click_on "Create Ingestion"

assert_text "Ingestion was successfully created"
click_on "Back"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

Valentine Kopotchel/2/Tracker/test/system/ingestions_test.rb
fill_in "User", with: @ingestion.user_id
click_on "Create Ingestion"

assert_text "Ingestion was successfully created"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

Valentine Kopotchel/2/Tracker/test/system/ingestions_test.rb
fill_in "Dish", with: @ingestion.dish_id
fill_in "Name", with: @ingestion.name
fill_in "User", with: @ingestion.user_id
click_on "Create Ingestion"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

Valentine Kopotchel/2/Tracker/test/system/ingestions_test.rb

fill_in "Dish", with: @ingestion.dish_id
fill_in "Name", with: @ingestion.name
fill_in "User", with: @ingestion.user_id
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

@valkovik15
Copy link
Contributor Author

Should I replace all the code by generators? Or it is OK?

@valkovik15 valkovik15 changed the title Valentine Kopotchel/2 Valentine Kopotchel - 2 Feb 28, 2019
@valkovik15
Copy link
Contributor Author

And is there a way to use new hash syntax in Slim views?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houndci-bot houndci-bot houndci-bot left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@valkovik15 @houndci-bot