Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alesia Yakutsionak - 1 #53

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Alesia Yakutsionak - 1 #53

wants to merge 14 commits into from

Conversation

als6k
Copy link
Contributor

@als6k als6k commented Feb 8, 2019 •
edited
Loading

Name

Alesia Yakutsionak

Homework#

1

Checklist

  • I have read homework assignment fully
  • I have implemented homework assignment fully
  • My pull request is named "#{name} #{surname} - #{homework_number}"
  • My code is located under "#{name} #{surname}/#{homework_number}"
  • It executes correctly
  • It doesn't crash, freeze, kill everyone on unexpected input
  • Credentials are NOT hardcoded you're making me hardcode credentials, which is the same thing.
  • Large files and credentials added to .gitignore INSIDE homework dir
  • It can be tested in under 10 minutes (download part + parse + execute)
  • Gemfile added, it runs under bundle exec without error

houndci-bot
houndci-bot reviewed Feb 8, 2019
View reviewed changes
Copy link

@houndci-bot houndci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Error: We found some problems with your configuration file: [/IrresponsibleMo... 
Error: We found some problems with your configuration file: [/IrresponsibleModule] key 'IrresponsibleModule:' is undefined., [/DuplicateMethodCall] key 'DuplicateMethodCall:' is undefined., [/UtilityFunction] key 'UtilityFunction:' is undefined.

Alesia Yakutsionak/1/pun_parser.rb Outdated Show resolved Hide resolved
Alesia Yakutsionak/1/pun_parser.rb Outdated Show resolved Hide resolved
Alesia Yakutsionak/1/pun_parser.rb Outdated Show resolved Hide resolved
Alesia Yakutsionak/1/pun_parser.rb Outdated Show resolved Hide resolved
Alesia Yakutsionak/1/pun_parser.rb Show resolved Hide resolved
Alesia Yakutsionak/1/pun_parser.rb Outdated Show resolved Hide resolved
Alesia Yakutsionak/1/pun_parser.rb Outdated Show resolved Hide resolved
Alesia Yakutsionak/1/bot.rb Outdated Show resolved Hide resolved
Alesia Yakutsionak/1/bot.rb Show resolved Hide resolved
@RGBD RGBD added the invalid This doesn't seem right label Feb 10, 2019
RGBD
RGBD requested changes Feb 10, 2019
View reviewed changes
Copy link
Collaborator

@RGBD RGBD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix rubocop issues, read token from file

Alesia Yakutsionak/1/bot.rb Outdated Show resolved Hide resolved
houndci-bot
houndci-bot reviewed Feb 10, 2019
View reviewed changes
Copy link

@houndci-bot houndci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Error: We found some problems with your configuration file: [/IrresponsibleMo... 
Error: We found some problems with your configuration file: [/IrresponsibleModule] key 'IrresponsibleModule:' is undefined., [/DuplicateMethodCall] key 'DuplicateMethodCall:' is undefined., [/UtilityFunction] key 'UtilityFunction:' is undefined.

houndci-bot
houndci-bot reviewed Feb 10, 2019
View reviewed changes
Copy link

@houndci-bot houndci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Error: We found some problems with your configuration file: [/IrresponsibleMo... 
Error: We found some problems with your configuration file: [/IrresponsibleModule] key 'IrresponsibleModule:' is undefined., [/DuplicateMethodCall] key 'DuplicateMethodCall:' is undefined., [/UtilityFunction] key 'UtilityFunction:' is undefined.

Alesia Yakutsionak/1/bot.rb Outdated Show resolved Hide resolved
houndci-bot
houndci-bot reviewed Feb 10, 2019
View reviewed changes
Copy link

@houndci-bot houndci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Error: We found some problems with your configuration file: [/IrresponsibleMo... 
Error: We found some problems with your configuration file: [/IrresponsibleModule] key 'IrresponsibleModule:' is undefined., [/DuplicateMethodCall] key 'DuplicateMethodCall:' is undefined., [/UtilityFunction] key 'UtilityFunction:' is undefined.

houndci-bot
houndci-bot reviewed Feb 10, 2019
View reviewed changes
Copy link

@houndci-bot houndci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Error: We found some problems with your configuration file: [/IrresponsibleMo... 
Error: We found some problems with your configuration file: [/IrresponsibleModule] key 'IrresponsibleModule:' is undefined., [/DuplicateMethodCall] key 'DuplicateMethodCall:' is undefined., [/UtilityFunction] key 'UtilityFunction:' is undefined.

Alesia Yakutsionak/1/bot.rb

private

def reply(bot, message)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Metrics/AbcSize: Assignment Branch Condition size for reply is too high. [16.12/15]

@als6k
Copy link
Contributor Author

als6k commented Feb 10, 2019

@RGBD it's ready for review

RGBD
RGBD requested changes Feb 10, 2019
View reviewed changes
Copy link
Collaborator

@RGBD RGBD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add Gemfile.lock to git
Otherwise ready to merge

@RGBD RGBD removed the invalid This doesn't seem right label Feb 10, 2019
@RGBD RGBD self-assigned this Feb 10, 2019
houndci-bot
houndci-bot reviewed Feb 17, 2019
View reviewed changes
Copy link

@houndci-bot houndci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Error: We found some problems with your configuration file: [/IrresponsibleMo... 
Error: We found some problems with your configuration file: [/IrresponsibleModule] key 'IrresponsibleModule:' is undefined., [/DuplicateMethodCall] key 'DuplicateMethodCall:' is undefined., [/UtilityFunction] key 'UtilityFunction:' is undefined.

@als6k
Copy link
Contributor Author

als6k commented Feb 17, 2019

@RGBD Done.

@als6k
Copy link
Contributor Author

als6k commented Mar 3, 2019

@RGBD it's ready to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houndci-bot houndci-bot houndci-bot left review comments

@RGBD RGBD RGBD requested changes

Assignees

@RGBD RGBD

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@als6k @houndci-bot @RGBD