-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alexandra Pozniak-0 #35
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some files could not be reviewed due to errors:
Error: We found some problems with your configuration file: [/IrresponsibleMo...
Error: We found some problems with your configuration file: [/IrresponsibleModule] key 'IrresponsibleModule:' is undefined., [/DuplicateMethodCall] key 'DuplicateMethodCall:' is undefined., [/UtilityFunction] key 'UtilityFunction:' is undefined.
end | ||
end | ||
|
||
def all_files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Metrics/MethodLength: Method has too many lines. [12/10]
0/Gemfile
Outdated
source 'https://rubygems.org' | ||
|
||
gem "roo", "~> 2.7.0" | ||
gem "roo-xls" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
Layout/TrailingBlankLines: Final newline missing.
0/Gemfile
Outdated
@@ -0,0 +1,4 @@ | |||
source 'https://rubygems.org' | |||
|
|||
gem "roo", "~> 2.7.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some files could not be reviewed due to errors:
Error: We found some problems with your configuration file: [/IrresponsibleMo...
Error: We found some problems with your configuration file: [/IrresponsibleModule] key 'IrresponsibleModule:' is undefined., [/DuplicateMethodCall] key 'DuplicateMethodCall:' is undefined., [/UtilityFunction] key 'UtilityFunction:' is undefined.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Удали из препозитория файлы с таблицами.
папка data должна быт добавлена в .gitignore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove
0/t_task.search(hash)
0/main.sublime-workspace
0/data/*
Перемести папку как просили в задании.
Чтобы всё лежало в "Имя Фамилия/0"
source 'https://rubygems.org' | ||
|
||
gem 'roo', '~> 2.7.0' | ||
gem 'roo-xls' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add newline at the end of file
@@ -0,0 +1,164 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove file from git
def denomination | ||
den = 0.0001 | ||
@tables.each do |cost| | ||
cost.values.inspect.map { |elem| den * elem.to_i } if cost.values[6].to_i > 100 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Непонятно, почему именно 6, сделай константу
.inspect возвращает строку, map упадёт с ошибкой.
def make_hash(file) | ||
names = file.column(1).drop(7) | ||
costs = file.column(15).drop(7) | ||
hash = names.zip(costs).to_h |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
names.zip(costs).select { |_key, value| value }.to_h
Name
Alexandra Pozniak
Homework#
0
Link to video with demo
https://www.youtube.com/watch?v=ecIWPzGEbFc
Comment
Level 1 and 2.