Maria Cheprasova - 0 #31

moooll · 2018-12-09T19:08:59Z

Name

Maria Cheprasova

Homework#

0

Link to video with demo

https://www.youtube.com/watch?v=ecIWPzGEbFc

Comment

Level 1, 2 and 3

houndci-bot

Some files could not be reviewed due to errors:

Error: We found some problems with your configuration file: [/IrresponsibleMo...

Error: We found some problems with your configuration file: [/IrresponsibleModule] key 'IrresponsibleModule:' is undefined., [/DuplicateMethodCall] key 'DuplicateMethodCall:' is undefined., [/UtilityFunction] key 'UtilityFunction:' is undefined.

houndci-bot · 2018-12-09T19:09:12Z

Maria Cheprasova/New folder/lvl1.rb

+else puts "#{arr_seek}"
+  end
+puts "#{count_files} files were found"
+end


Layout/TrailingBlankLines: Final newline missing.

houndci-bot · 2018-12-09T19:09:13Z

Maria Cheprasova/New folder/lvl1.rb

+    puts "nothing"
+else puts "#{arr_seek}"
+  end
+puts "#{count_files} files were found"


Layout/IndentationConsistency: Inconsistent indentation detected.

houndci-bot · 2018-12-09T19:09:13Z

Maria Cheprasova/New folder/lvl1.rb

+end
+  if arr_seek.empty?
+    puts "nothing"
+else puts "#{arr_seek}"


Layout/ElseAlignment: Align else with if.
Style/UnneededInterpolation: Prefer to_s over string interpolation.

houndci-bot · 2018-12-09T19:09:13Z

Maria Cheprasova/New folder/lvl1.rb

+  end
+end
+  if arr_seek.empty?
+    puts "nothing"


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2018-12-09T19:09:13Z

Maria Cheprasova/New folder/lvl1.rb

+workbook.each do |worksheet_rows|
+  worksheet_rows.select { |row| row&.cells&.at(0)&.value }.each_with_index do |row, index|
+    if row&.cells[14]&.value==seek
+      arr_seek.push(row&.cells[0]&.value)


Lint/SafeNavigationChain: Do not chain ordinary method call after safe navigation operator.

houndci-bot · 2018-12-09T19:09:14Z

Maria Cheprasova/New folder/lvl1.rb

+    end
+end
+  arr_seek=Array.new
+  if num_rows!=0


Style/IfUnlessModifier: Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||.
Layout/SpaceAroundOperators: Surrounding space missing for operator !=.

houndci-bot · 2018-12-09T19:09:14Z

Maria Cheprasova/New folder/lvl1.rb

+    ind_min=i
+    end
+end
+  arr_seek=Array.new


Layout/SpaceAroundOperators: Surrounding space missing for operator =.
Style/EmptyLiteral: Use array literal [] instead of Array.new.

houndci-bot · 2018-12-09T19:09:14Z

Maria Cheprasova/New folder/lvl1.rb

+  if arr_price[i]<min
+    min=arr_price[i]
+    ind_min=i
+    end


Layout/EndAlignment: end at 64, 4 is not aligned with if at 61, 2.

houndci-bot · 2018-12-09T19:09:14Z

Maria Cheprasova/New folder/lvl1.rb

+  end
+  if arr_price[i]<min
+    min=arr_price[i]
+    ind_min=i


Layout/SpaceAroundOperators: Surrounding space missing for operator =.

houndci-bot · 2018-12-09T19:09:15Z

Maria Cheprasova/New folder/lvl1.rb

+    ind_max=i
+  end
+  if arr_price[i]<min
+    min=arr_price[i]


Layout/SpaceAroundOperators: Surrounding space missing for operator =.

RGBD

Таблицы надо удалить из репозитория

RGBD · 2018-12-09T19:29:22Z

Maria Cheprasova/New folder/data/desktop.ini

@@ -0,0 +1,10 @@
+[LocalizedFileNames]


remove file

RGBD · 2018-12-09T19:31:19Z

Maria Cheprasova/New folder/lvl1.rb

+    puts " #{item_name}: #{price}"
+    end
+    end
+end


houndci-bot

Some files could not be reviewed due to errors:

Error: We found some problems with your configuration file: [/IrresponsibleMo...

Error: We found some problems with your configuration file: [/IrresponsibleModule] key 'IrresponsibleModule:' is undefined., [/DuplicateMethodCall] key 'DuplicateMethodCall:' is undefined., [/UtilityFunction] key 'UtilityFunction:' is undefined.

houndci-bot · 2018-12-09T20:33:55Z

Maria Cheprasova/New folder/lvl1.rb

+  puts 'nothing'
+else
+  arr_seek.to_s
+  puts "#{arr_seek.to_s}"


Style/UnneededInterpolation: Prefer to_s over string interpolation.
Lint/StringConversionInInterpolation: Redundant use of Object#to_s in interpolation.

houndci-bot · 2018-12-09T20:33:55Z

Maria Cheprasova/New folder/lvl1.rb

+    ind_min = i
+  end
+end
+arr_seek = Array.new


Style/EmptyLiteral: Use array literal [] instead of Array.new.

houndci-bot · 2018-12-09T20:33:55Z

Maria Cheprasova/New folder/lvl1.rb

+num_rows = 0
+arr_name = Array.new
+arr_price = Array.new
+arr_date = Array.new


Style/EmptyLiteral: Use array literal [] instead of Array.new.

houndci-bot · 2018-12-09T20:33:55Z

Maria Cheprasova/New folder/lvl1.rb

+count_files = 0
+num_rows = 0
+arr_name = Array.new
+arr_price = Array.new


Style/EmptyLiteral: Use array literal [] instead of Array.new.

houndci-bot · 2018-12-09T20:33:55Z

Maria Cheprasova/New folder/lvl1.rb

+seek = price_to_seek
+count_files = 0
+num_rows = 0
+arr_name = Array.new


Style/EmptyLiteral: Use array literal [] instead of Array.new.

Maria Cheprasova/New folder/Gemfile

houndci-bot

Some files could not be reviewed due to errors:

Error: We found some problems with your configuration file: [/IrresponsibleMo...

Error: We found some problems with your configuration file: [/IrresponsibleModule] key 'IrresponsibleModule:' is undefined., [/DuplicateMethodCall] key 'DuplicateMethodCall:' is undefined., [/UtilityFunction] key 'UtilityFunction:' is undefined.

houndci-bot

Some files could not be reviewed due to errors:

Error: We found some problems with your configuration file: [/IrresponsibleMo...

Error: We found some problems with your configuration file: [/IrresponsibleModule] key 'IrresponsibleModule:' is undefined., [/DuplicateMethodCall] key 'DuplicateMethodCall:' is undefined., [/UtilityFunction] key 'UtilityFunction:' is undefined.

houndci-bot

Some files could not be reviewed due to errors:

Error: We found some problems with your configuration file: [/IrresponsibleMo...

Error: We found some problems with your configuration file: [/IrresponsibleModule] key 'IrresponsibleModule:' is undefined., [/DuplicateMethodCall] key 'DuplicateMethodCall:' is undefined., [/UtilityFunction] key 'UtilityFunction:' is undefined.

houndci-bot

Some files could not be reviewed due to errors:

Error: We found some problems with your configuration file: [/IrresponsibleMo...

Error: We found some problems with your configuration file: [/IrresponsibleModule] key 'IrresponsibleModule:' is undefined., [/DuplicateMethodCall] key 'DuplicateMethodCall:' is undefined., [/UtilityFunction] key 'UtilityFunction:' is undefined.

RGBD · 2018-12-10T12:41:43Z

Maria Cheprasova/0/lvl1.rb

+  puts "Lowest #{min} #{arr_date[ind_min]}"
+  puts ", highest was #{max} #{arr_date[ind_max]}"
+end
+puts 'You can also buy '.chomp


chomp not needed

RGBD · 2018-12-10T12:46:34Z

Maria Cheprasova/0/lvl1.rb

+ans = gets.chomp
+worksheets.each do |worksheet_rows|
+  worksheet_rows.select { |row| row.at(0).value }.each_with_index do |row, _|
+    row.each_with_index do |_, cell_index|


you don't need to iterate over row, you only use row[14] and row[0]

RGBD · 2018-12-10T12:49:15Z

Maria Cheprasova/0/lvl1.rb

+    end
+  end
+end
+seek = price_to_seek


you don't need another variable, just use price_to_seek

RGBD · 2018-12-10T12:53:51Z

Maria Cheprasova/0/lvl1.rb

+ind_max = 0
+max = arr_price[0]
+min = arr_price[0]
+arr_price.each_index do |i|


ind_min = arr_price.index(arr_price.min)
min = arr_price[ind_min]

These two are interchangeable?
+What does this statement mean? (arr_price.min)

2.5.1 (main):0 > arr_price = ["f", "c", "d", "f", "h", "b", "i"]; 2.5.1 (main):0 > arr_price.index("f") => 0 2.5.1 (main):0 > arr_price.index("d") => 2 2.5.1 (main):0 > arr_price.min => "b"

https://ruby-doc.org/core-2.2.0/Array.html#method-i-index
https://ruby-doc.org/core-2.5.3/Enumerable.html#method-i-min

Sorry, but houndci-bot left such a remark for me "Error: We found some problems with your configuration file: [/IrresponsibleModule] key 'IrresponsibleModule:' is undefined., [/DuplicateMethodCall] key 'DuplicateMethodCall:' is undefined., [/UtilityFunction] key 'UtilityFunction:' is undefined."
as I understood one of te errors happened due to several duplicate parts of code. but I don't know exactly where they are. mb u can help me with the reason why this error happens?

RGBD · 2018-12-10T12:55:11Z

Maria Cheprasova/0/lvl1.rb

+    ind_min = i
+  end
+end
+arr_seek []


This shouldn't work, did you mean arr_seek = []?

RGBD · 2018-12-10T12:55:52Z

Maria Cheprasova/0/lvl1.rb

+end
+puts 'You can also buy '.chomp
+workbook.each do |worksheet_rows|
+  worksheet_rows.select { |row| row.at(0).value }.each_with_index do |row, _|


use each if you don't care about index

houndci-bot

Some files could not be reviewed due to errors:

Error: We found some problems with your configuration file: [/IrresponsibleMo...

Error: We found some problems with your configuration file: [/IrresponsibleModule] key 'IrresponsibleModule:' is undefined., [/DuplicateMethodCall] key 'DuplicateMethodCall:' is undefined., [/UtilityFunction] key 'UtilityFunction:' is undefined.

houndci-bot · 2018-12-11T10:45:17Z

Maria Cheprasova/0/lvl1.rb

+    item_name = row[0].value
+      price = row[14].value || 'unknown'
+      price_to_seek = price
+      puts " #{item_name}: #{price}"


Layout/IndentationConsistency: Inconsistent indentation detected.

houndci-bot · 2018-12-11T10:45:17Z

Maria Cheprasova/0/lvl1.rb

+
+    item_name = row[0].value
+      price = row[14].value || 'unknown'
+      price_to_seek = price


Layout/IndentationConsistency: Inconsistent indentation detected.

houndci-bot · 2018-12-11T10:45:17Z

Maria Cheprasova/0/lvl1.rb

+    next if row[0].value.include?(ans)
+
+    item_name = row[0].value
+      price = row[14].value || 'unknown'


Layout/IndentationConsistency: Inconsistent indentation detected.

houndci-bot

Some files could not be reviewed due to errors:

Error: We found some problems with your configuration file: [/IrresponsibleMo...

Error: We found some problems with your configuration file: [/IrresponsibleModule] key 'IrresponsibleModule:' is undefined., [/DuplicateMethodCall] key 'DuplicateMethodCall:' is undefined., [/UtilityFunction] key 'UtilityFunction:' is undefined.

RGBD

Couldn't run the program.
Please, check your code before commit.

RGBD · 2018-12-14T14:41:35Z

Maria Cheprasova/0/Gemfile

@@ -0,0 +1,4 @@
+source 'https://rubygems.org'
+
+gem 'find'


gem not found

% bundle install Fetching gem metadata from https://rubygems.org/.............. Fetching gem metadata from https://rubygems.org/. Could not find gem 'find' in any of the gem sources listed in your Gemfile.

RGBD · 2018-12-14T14:44:23Z

Maria Cheprasova/0/lvl1.rb

+puts 'What price are you looking for?'
+ans = gets
+worksheets.each do |worksheet_rows|
+  worksheet_rows.select { |row| row.at(0).value }.each do |row|


What price are you looking for? Соль Traceback (most recent call last): 7: from lvl1.rb:8:in `<main>' 6: from lvl1.rb:8:in `each' 5: from lvl1.rb:9:in `block in <main>' 4: from lvl1.rb:9:in `select' 3: from /home/oleg/.rvm/rubies/ruby-2.5.3/lib/ruby/gems/2.5.0/gems/rubyXL-3.3.31/lib/rubyXL/worksheet.rb:23:in `each' 2: from /home/oleg/.rvm/rubies/ruby-2.5.3/lib/ruby/gems/2.5.0/gems/rubyXL-3.3.31/lib/rubyXL/worksheet.rb:23:in `each' 1: from /home/oleg/.rvm/rubies/ruby-2.5.3/lib/ruby/gems/2.5.0/gems/rubyXL-3.3.31/lib/rubyXL/worksheet.rb:23:in `block in each' lvl1.rb:9:in `block (2 levels) in <main>': undefined method `at' for #<RubyXL::Row:0x000055f6c3c9e158> (NoMethodError)

RGBD · 2018-12-14T14:56:17Z

Maria Cheprasova/0/lvl1.rb

+ans = gets
+worksheets.each do |worksheet_rows|
+  worksheet_rows.select { |row| row.at(0).value }.each do |row|
+    next if cell_index.positive?


cell_index unedfined local variable

RGBD · 2018-12-14T14:57:33Z

Maria Cheprasova/0/lvl1.rb

+workbook = RubyXL::Parser.parse './data/Average_prices(serv)-10-2018.xlsx'
+worksheets = workbook.worksheets
+puts 'What price are you looking for?'
+ans = gets


.

36157d6

houndci-bot reviewed Dec 9, 2018

View reviewed changes

RGBD self-assigned this Dec 9, 2018

RGBD requested changes Dec 9, 2018

View reviewed changes

Upd lvl1.rb

2ab1e46

houndci-bot reviewed Dec 9, 2018

View reviewed changes

moooll added 2 commits December 9, 2018 23:44

Update Gemfile

1aecbb4

.

c61c6df

houndci-bot reviewed Dec 9, 2018

View reviewed changes

Update lvl1.rb

ef71397

houndci-bot reviewed Dec 9, 2018

View reviewed changes

upd2

5a5913d

houndci-bot reviewed Dec 9, 2018

View reviewed changes

0

746444a

houndci-bot reviewed Dec 10, 2018

View reviewed changes

RGBD requested changes Dec 10, 2018

View reviewed changes

Update lvl1.rb

d0822ff

houndci-bot reviewed Dec 11, 2018

View reviewed changes

Update lvl1.rb

8da4f05

houndci-bot reviewed Dec 13, 2018

View reviewed changes

RGBD requested changes Dec 14, 2018

View reviewed changes

Maria Cheprasova - 0 #31

Are you sure you want to change the base?

Maria Cheprasova - 0 #31

Conversation

moooll commented Dec 9, 2018

Name

Homework#

Link to video with demo

Comment

houndci-bot left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

RGBD left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

houndci-bot left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

houndci-bot left a comment

Choose a reason for hiding this comment

houndci-bot left a comment

Choose a reason for hiding this comment

houndci-bot left a comment

Choose a reason for hiding this comment

houndci-bot left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

moooll Dec 11, 2018 • edited Loading

Choose a reason for hiding this comment

RGBD Dec 11, 2018 • edited Loading

Choose a reason for hiding this comment

moooll Dec 14, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

houndci-bot left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

houndci-bot left a comment

Choose a reason for hiding this comment

RGBD left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

moooll Dec 11, 2018 •

edited

Loading

RGBD Dec 11, 2018 •

edited

Loading

moooll Dec 14, 2018 •

edited

Loading