Remove limit from tags endpoint parameter

Signed-off-by: Ruben Vargas <[email protected]>

modules/frontend/tagsharding.go

@@ -33,9 +33,6 @@ func (s searchTagSharder) RoundTrip(r *http.Request) (*http.Response, error) {
 		}, nil
 	}
 
-	// adjust limit based on config
-	searchReq.Limit = adjustLimit(searchReq.Limit, s.cfg.DefaultLimit, s.cfg.MaxLimit)
-
 	requestCtx := r.Context()
 	tenantID, err := user.ExtractOrgID(requestCtx)
 	if err != nil {
@@ -79,7 +76,7 @@ func (s searchTagSharder) RoundTrip(r *http.Request) (*http.Response, error) {
 
 	// execute requests
 	wg := boundedwaitgroup.New(uint(s.cfg.ConcurrentRequests))
-	taghandler := s.tagShardHandlerFactory(ctx, int(searchReq.Limit))
+	taghandler := s.tagShardHandlerFactory(ctx, 0)
 
 	progress := taghandler.progress()
 	for req := range reqCh {

pkg/api/http.go

@@ -705,46 +705,6 @@ func BuildSearchTagRequest(req *http.Request, searchReq *tempopb.SearchTagsReque
 	q := req.URL.Query()
 	q.Set(urlParamStart, strconv.FormatUint(uint64(searchReq.Start), 10))
 	q.Set(urlParamEnd, strconv.FormatUint(uint64(searchReq.End), 10))
-	if searchReq.Limit != 0 {
-		q.Set(urlParamLimit, strconv.FormatUint(uint64(searchReq.Limit), 10))
-	}
-
-	req.URL.RawQuery = q.Encode()
-
-	return req, nil
-}
-
-func BuildTagSearchBlockRequest(req *http.Request, searchReq *tempopb.SearchTagsBlockRequest) (*http.Request, error) {
-	if req == nil {
-		req = &http.Request{
-			URL: &url.URL{},
-		}
-	}
-
-	req, err := BuildSearchTagRequest(req, searchReq.SearchReq)
-	if err != nil {
-		return nil, err
-	}
-
-	q := req.URL.Query()
-	q.Set(urlParamSize, strconv.FormatUint(searchReq.Size_, 10))
-	q.Set(urlParamBlockID, searchReq.BlockID)
-	q.Set(urlParamStartPage, strconv.FormatUint(uint64(searchReq.StartPage), 10))
-	q.Set(urlParamPagesToSearch, strconv.FormatUint(uint64(searchReq.PagesToSearch), 10))
-	q.Set(urlParamEncoding, searchReq.Encoding)
-	q.Set(urlParamIndexPageSize, strconv.FormatUint(uint64(searchReq.IndexPageSize), 10))
-	q.Set(urlParamTotalRecords, strconv.FormatUint(uint64(searchReq.TotalRecords), 10))
-	q.Set(urlParamDataEncoding, searchReq.DataEncoding)
-	q.Set(urlParamVersion, searchReq.Version)
-	q.Set(urlParamFooterSize, strconv.FormatUint(uint64(searchReq.FooterSize), 10))
-	if len(searchReq.DedicatedColumns) > 0 {
-		columnsJSON, err := json.Marshal(searchReq.DedicatedColumns)
-		if err != nil {
-			return nil, err
-		}
-		q.Set(urlParamDedicatedColumns, string(columnsJSON))
-	}
-
 	req.URL.RawQuery = q.Encode()
 
 	return req, nil

pkg/tempopb/tempo.proto

@@ -137,7 +137,6 @@ message SearchMetrics {
 
 message SearchTagsRequest {
   string scope = 1;
-  uint32 Limit = 2;
   uint32 start = 3;
   uint32 end = 4;
 }