Labs: GitHub-177: Randomly generate log file's name to enhance log file's security #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishalkakadiya
changed the title
vishalkakadiya
changed the title
|
Can you check why Playwright tests are failing |
|
@pavanpatil1 Can you help here to fix these errors or guide me the next steps as we discussed in the Slack. Thanks! CC @gagan0123 |
|
@gagan0123 The tests are fixed and passed now in the CI as well as in the local. Can you review the PR now, thanks! 🙂 CI: https://github.com/rtCamp/nginx-helper/actions/runs/7484035307/job/20370229295?pr=311#step:6:4239 Local:
|
|
Closing this PR as opened the new PR as discussed with the team. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nginx-Helper generates a predictable log file on a predefined path, so we are generating the file name randomly so it will be not detected by anyone else then the site Admin.
Ref: https://github.com/rtCamp/labs/issues/177