Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README更新 #10

Merged
merged 3 commits into from
Nov 10, 2023
Merged

README更新 #10

merged 3 commits into from
Nov 10, 2023

Conversation

Kuwamai
Copy link
Collaborator

@Kuwamai Kuwamai commented Nov 9, 2023

What does this implement/fix?

READMEの内容をROS 2に対応させました。

Does this close any currently open issues?

しません

How has this been tested?

ドキュメントのみの更新です

Any other comments?

なし

Checklists

@Kuwamai Kuwamai added the Type: Documentation Documentation only changes label Nov 9, 2023
@Kuwamai Kuwamai self-assigned this Nov 9, 2023
@Kuwamai Kuwamai changed the base branch from main to ros2 November 9, 2023 07:20
@Kuwamai Kuwamai requested a review from ShotaAk November 9, 2023 07:21
Copy link

@ShotaAk ShotaAk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

コメントの確認お願いします。

README.md Outdated
rosdep install -r -y -i --from-paths .

# パッケージをビルドする
cd ~/catkin_ws
cd ~/ros2_ws
catkin_make
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
catkin_make

```

## 使用方法

次のコマンドを実行するとRViz上にSciurus17のモデルが表示されます

```sh
roslaunch sciurus17_description display.launch
ros2 launch sciurus17_description display.launch.py
```

![display_launch](https://rt-net.github.io/images/sciurus17/display_launch.png)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

画像ではTFも表示されてますが、diplay.launch.pyを実行するとTFが出てこないです。

TFも表示するようにrvizのコンフィグファイルを更新してください。

README.en.md Outdated
rosdep install -r -y -i --from-paths .

# Build the package
cd ~/catkin_ws
cd ~/ros2_ws
catkin_make
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
catkin_make

Copy link

@ShotaAk ShotaAk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShotaAk ShotaAk merged commit 9899c74 into ros2 Nov 10, 2023
2 checks passed
@ShotaAk ShotaAk deleted the update_readme branch November 10, 2023 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Documentation Documentation only changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants