-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some more OpenCV fixes #56
Conversation
Do we really need the Xenial builds? I don't feel we're getting any info from them which is not there in the Bionic ones. Maybe remove some of them? Just a thought |
Okay, this is getting frustrating now, download of
|
Problem with
Note that the job may show it has passed but the problem could still be there, since there's no |
Did a bit of testing for this, shell script used is given below -
Output with
Side note: |
3341e79
to
dbfc96f
Compare
I think that OpenCV is using the compiled FFmpeg libraries since that was the problem of #52, but have also mentioned in the first point in #20, with an example of Edit: The latest commit shouldn't make any difference in the build if it's all working as intended
with-libs.txt |
86226e7
to
15466a6
Compare
Yes, would recommend keeping 16.04 at least till 20.04 reaches decent adoption |
Would actually recommend keeping the alias :) |
Yeah, was just a thought I had after looking at 10 builds 😅 . Even then, meant "all the Xenial builds", should have mentioned that, cancelling specific builds works just as well. Can't say against this, since I was also using 16.04 till about a month ago
Do have a bit of habit of using cat for copying files, aliasing will remove that habit at least :). Already added back the alias |
cat followed by xclip? |
Yeah, |
Problem doesn't seem to be solved, the difference in library versions can be seen from the output of
Did a test build with verbose output - https://travis-ci.com/rajat2004/Ubuntu-Setup-Scripts/builds/143082037 |
Did some more testing, with the While testing with Docker, there were problems with users and it creating new login session and stopping the execution of the script in between. Will need to work on making the Docker environment more resembling a system install. Or a different virtual env system. Though that does bring up another point, CMake is finding the system libs whereas the linker errors if it doesn't locate the source built libs. |
The last commit can be dropped since it's somewhat hiding the issue that different codecs are being used, and committed later when confirmed that things are working as expected |
Shit, such a simple thing which I overlooked. The Travis build may show different versions, but didn't even check on my system. This will teach me not to go into complicated things without first verifying the simple way. OpenCV build info -
FFmpeg -
Changes in the PR are the same as the ones I did on my system, so I guess it should be okay |
Renaming the anaconda libraries back to the original names after the compilation should work ideally, because during the build, it should link to the non-anaconda versions of the libraries, and that should be permanent (ideally, not sure how they are linking). Any chance you can test this? |
Haha looks like it might be something specific to how Travis handles things then |
Will try, I'm installing VirtualBox on my system today for proper testing, and to avoid some of the headaches I'm having right now with Docker. Will be useful for the Zsh+Zim update also
I'm having suspicions about the whole thing since the culprit seemed to be the paths, I added the LD_LIBRARY and other paths in the settings as was earlier (so maybe should have only removed the modification to PATH). But no difference, still the same |
Wasn't able to get any testing done till now, VirtualBox installation and setup also took longer than expected |
Cleaned up the commits, but as mentioned, this doesn't change the paths, and so OpenCV finds the system libraries |
Another option is that we can execute the scripts using |
@rsnk96 I think I've got it! Made 2 changes, first didn't execute the script but used Source - https://askubuntu.com/questions/606378/when-to-use-vs-in-bash |
It's working!
Would like to have a final review done, then will clean up commits and add note in Readme for this |
c3f394b
to
d55e440
Compare
Commits cleaned up a bit, note added |
Awesome stuff! :) |
@rsnk96 I think this PR is good to go, would be great to have your review once to see if anything is still missing or needs fixing |
Hey. I updated my review questions inline (can be seen in
|
@rsnk96 Review comments are not visible :) I think you'll need to submit it again, that has occurred with me before as well
I think so, since
Sure, will make the changes
I'm not sure about this, will test! |
It does seem to be working - https://travis-ci.com/rajat2004/Ubuntu-Setup-Scripts/builds/145216554 |
Build running right now - https://travis-ci.com/rajat2004/Ubuntu-Setup-Scripts/builds/145223052 |
Also test FFmpeg and OpenCV installation after script completes
d55e440
to
5d61dda
Compare
I've removed the |
Looks like it worked! This is a good PR, feel free to merge it whenever you're ready |
@rsnk96 I think it's all working correctly, tested in a docker container, OpenCV working correctly after undoing the rename, reboot, as well as I'll mostly wait till tonight, for either of us to check something else if anything pops up, but looks okay to me as well Edit: Squashed the Conda renaming commits |
5d61dda
to
597e264
Compare
Merging, all builds look okay, more changes needed can be done in another PR 😅 |
... Part 3
Issue #52
ld.so.conf.d
nasm
,yasm
install toapt
, removesu $USER