-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenCV Improvements & Fixes Part 2 #54
Conversation
0af426e
to
92644fa
Compare
@rsnk96 Any idea why Anaconda is present in the PATH? Other things look okay- |
Can't think of a reason |
Hmm, I'm not seeing this problem when testing on a separate branch with the current branch as the base PATH - Branch - https://github.com/rajat2004/Ubuntu-Setup-Scripts/tree/opencv-fixes-test Let's see... |
@rsnk96 Got it! It was in the most obvious place which I had completely neglected to look at. I'll drop the commits for testing of the paths, probably the changes to the paths in the settings are not needed since they have not been made in my own repo, and the builds are passing, but will look into this more deeply first |
da06984
to
f3b2c60
Compare
Remove deprecated keys, update aliased keywords
8ac375a
to
5793352
Compare
The last commit is something which I feel is good to have but can be removed. Any thoughts? |
Good find on Travis's path! |
@rsnk96 Thanks! I think it should be okay to remove the path modifications, but would like to confirm that. This PR also seems to be good to go |
The current PATH settings in Travis - |
Removed all the modifications and Travis build is passing, everything looks okay |
Issue - #20