Adds 'should reject and not refund a pegout when a contract is trying… #156
Conversation
jeremy-then
force-pushed
the
add-pegout-with-fee-above-value-test
branch
2 times, most recently
from
f39a419
to
f5065f6
Compare
… to execute it' test Cherry-picking pegout from contract commit Rebasing
to version 1.1.4
jeremy-then
force-pushed
the
add-pegout-request-from-contract-test
branch
from
11c5790
to
913b560
Compare
lib/contractDeployer.js
Outdated
| const deployCallReleaseBtcContract = async (rskTxHelper) => { | ||
|
|
||
| const address = await rskTxHelper.getClient().eth.personal.newAccount(''); | ||
| await sendFromCow(rskTxHelper, address, Number(btcToWeis(0.5))); |
There was a problem hiding this comment.
I think we have a constant for 0.5 now? maybe I am wrong :)
There was a problem hiding this comment.
Good catch! Updated.
|
| const TEST_RELEASE_BTC_CONTRACT = '../contracts/CallReleaseBtcContract.sol'; | ||
| const TEST_RELEASE_BTC_CONTRACT_NAME = 'CallReleaseBtcContract'; |
There was a problem hiding this comment.
If this a generic contract deployer perhaps these values should be received by param then?
| ); | ||
|
|
||
| return { | ||
| creatorAddress: address, |
There was a problem hiding this comment.
Is this valuable? Shouldn't we simply return the contract address?
| const pegoutValueInSatoshis = MINIMUM_PEGOUT_AMOUNT_IN_SATOSHIS; | ||
|
|
||
| const { callReleaseBtcContract, creatorAddress } = await deployCallReleaseBtcContract(rskTxHelper); | ||
| const initialRskSenderBalanceInWeisBN = await rskTxHelper.getBalance(creatorAddress); |
There was a problem hiding this comment.
It doesn't have to be the contract creator the one that makes the call right? It can be any address
|
|
||
| await assert2wpBalancesAfterPegoutFromContract(initial2wpBalances, pegoutValueInSatoshis); | ||
|
|
||
| // The rsk sender should lose the funds since there's no refund when a smart contract is trying to do a pegout |
There was a problem hiding this comment.
Should we also be checking the contract address balance?
Adds 'should reject and not refund a pegout when a contract is trying to execute it' test