Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

US-2160 User would like to add a contact from the Transaction Summary screen so they can send to them later #905

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

TravellerOnTheRun
Copy link
Collaborator

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-03-04.at.12.53.31.mp4

@TravellerOnTheRun
Copy link
Collaborator Author

@jormelCoin @jessgusclark
Let's first merge use-wallet branch, I rebased this one on top of that.

@TravellerOnTheRun TravellerOnTheRun added the dont merge Do not merge this PR label Mar 4, 2024
@jormelCoin
Copy link
Contributor

Hey @TravellerOnTheRun, I haven't completed the tests of this PR. However, I saw two things:
1- When entering to send screen, I got an alert message.
2- I see a question mark as an icon.
Screenshot 2024-03-20 at 10 25 40

Copy link
Contributor

@jormelCoin jormelCoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TravellerOnTheRun, apart from the other comment, I found the following:
1-When receiving BTC, the option to add a contact appears, yet as we all know, that address cannot be saved as a contact.

20240320_204012.mp4

2- I can save different contacts with the same name, it's an old issue.

20240320_204410.mp4

Copy link
Member

@jessgusclark jessgusclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question mark shows for me also, and the dropdown in the video does not show for me when I rebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants