US-1964 WalletConnect sessions don't get erased when the wallet is reset #900
Conversation
There was a problem hiding this comment.
This PR is changing a few things out of the scope of the ticket, like transforming all the address references from the wallet to the addressToUse function.
I guess this is okay, only one thing that has to be addressed. What I suggest is that we don't modify anything related to the mmkv storage, instead, focus on deleting the wallet connect mmkv storage when the wallet is reset.
TravellerOnTheRun
force-pushed
the
us-1964
branch
from
3c09570
to
d2135f6
Compare
|
@jessgusclark @Freshenext |
|
|
||
| export const getCurrentChainId: () => ChainID = () => | ||
| ChainStorage.get('chainId') || 31 | ||
| MainStorage.get('chainId') || 31 |
There was a problem hiding this comment.
Why is this ChainStorage being changed to MainStorage? 🤔
There was a problem hiding this comment.
Because there was no need to do a separate instance just for chainId
There was a problem hiding this comment.
Have you tested to make sure that testnet and mainnet switch are working ok?
And also wallet reset on testnet
And also wallet reset on mainnet
I ask because changing it could potentially alter the behavior of the wallet
There was a problem hiding this comment.
We're calling getCurrentChainId everytime when we need to fetch chainId
There was a problem hiding this comment.
Video proof
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-03-06.at.12.36.21.mp4
| @@ -21,7 +22,8 @@ import { | |||
| import { useAppDispatch, useAppSelector } from 'store/storeUtils' | |||
| import { selectChainId } from 'store/slices/settingsSlice' | |||
| import { addPendingTransaction } from 'store/slices/transactionsSlice' | |||
| import { createPendingTxFromTxResponse } from 'src/lib/utils' | |||
| import { Wallet } from 'shared/wallet' | |||
| import { addressToUse } from 'shared/hooks' | |||
There was a problem hiding this comment.
import { addressToUse } from 'shared/wallet'
No description provided.