-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
US-2157: Round USD conversions #890
Conversation
adb61f8
to
6e55c88
Compare
@rodrigoncalves |
Of course! That's why this PR is in draft, I'm still playing around with it. The |
6e55c88
to
9daca3f
Compare
src/ux/requestsModal/ReviewRelayTransaction/ReviewTransactionContainer.tsx
Show resolved
Hide resolved
962ba38
to
fb8d992
Compare
b71ea9e
to
04e51b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some changes are still required for future proofing the app
164d31d
to
b0ca8ca
Compare
b0ca8ca
to
ba7a56b
Compare
src/ux/requestsModal/ReviewRelayTransaction/ReviewTransactionContainer.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still see the NaN in Bitcoin transactions. @jessgusclark, when you get a chance, could you, please take a look? Rodrigo says it works well for him but for me fails since I still see the NaN. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I carried out the tests and it worked very well both iOS and Android.
As suggested by @TravellerOnTheRun, I decided to not only modify the existing
formatTokenValues
function, but split into 2 different functions (formatTokenValue
andformatFiatValue
) that each use a genericformatNumber
function. This function expands the current implementation and now it should cover all different cases present in the application.Below are a few screenshots showing the implementation in action. Please let me know if I missed anything.