US-2128: Change the order of tokens list to match the following sequence: RIF, USDRIF, RBTC, BTC, RDOC & others #886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigoncalves
force-pushed
the
us-2128
branch
from
77dc9c0
to
e84254f
Compare
TravellerOnTheRun
requested changes
Feb 6, 2024
rodrigoncalves
force-pushed
the
us-2128
branch
from
719a4fb
to
13a5346
Compare
TravellerOnTheRun
requested changes
Feb 8, 2024
rodrigoncalves
force-pushed
the
us-2128
branch
from
935f575
to
83245fa
Compare
jessgusclark
requested changes
Feb 12, 2024
rodrigoncalves
force-pushed
the
us-2128
branch
from
83245fa
to
1d16fdf
Compare
rodrigoncalves
force-pushed
the
us-2128
branch
from
1d16fdf
to
f4807cf
Compare
jormelCoin
approved these changes
Feb 20, 2024
TravellerOnTheRun
requested changes
Feb 21, 2024
| @@ -24,11 +29,14 @@ export const PortfolioComponent = ({ | |||
| showTotalCard = true, | |||
| style, | |||
| }: Props) => { | |||
| const chainId = useAppSelector(selectChainId) | |||
There was a problem hiding this comment.
it's better if we use getCurrentChainId since anytime we switch networks we modify this, it will make the chainId fetching more consistent and it can be used everywhere.
src/screens/home/TokenImage.tsx
Outdated
| @@ -277,3 +279,24 @@ export const getIconSource = ( | |||
| return undefined | |||
| } | |||
| } | |||
|
|
|||
| export const getTokenByChainId = ( | |||
There was a problem hiding this comment.
getTokenSymbolByChainId will be more appropriate name for this function as that's what it returns.
There was a problem hiding this comment.
I agree, done.
jessgusclark
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.