-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
US-2101 Refactor RNS registration screens for better readability and remove circular dependencies #883
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TravellerOnTheRun, I was able to create a new RNS and also to put my old RNS.
Nonetheless, The fee transaction is wrong because is showing up as 0 TRBTC and it should be one in TRBTC and the other one in RIF like it's in production:
Tested relay true
Did you compare it to recent develop? |
Yep, you're right, it shows up the RBTC. Nevertheless, in the development branch, the amount of the transaction that is deducted appears in RIF even though TRBTC appears in the browser, I assume it is because we show the fee charged in rif. If you notice on the confirmation screen, you are not charging the 4 RIF that are charged, and they should be charged because this is the relay version, and those 4 RIF are what we should show in the transaction summary. Evidence of this PR: 20240208_102944.mp4Evidence of the latest build RPReplay_Final1707401860.MP4cc: @jessgusclark |
055da1a
to
d61f59a
Compare
The thing is that these issues are related to the fact how @jormelCoin |
@jormelCoin @jessgusclark |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional tests pass
@jormelCoin the job for you is to test that the domain registration works as it was.