Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: single source chainId type #882

Merged
merged 3 commits into from
Feb 9, 2024
Merged

refactor: single source chainId type #882

merged 3 commits into from
Feb 9, 2024

Conversation

TravellerOnTheRun
Copy link
Collaborator

@TravellerOnTheRun TravellerOnTheRun commented Feb 5, 2024

Not that we have ChainID type from EOAWallet we can use it. @jormelCoin make sure nothing breaks after this PR.

Copy link
Member

@jessgusclark jessgusclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I load this up and try to recover via a mnemonic it doesn't create the wallet, rather it deletes some of the inputs and restarts. I checked that the develop branch is working correctly.

See video of this branch:

mnemonic-recovery-issue.mov

@TravellerOnTheRun
Copy link
Collaborator Author

@jessgusclark
Please, check again, getWalletSetting was used the old way, I believe I've changed it in my EOA PR maybe someone committed those changes back accidentally we need to watch closely what's committed.

@jessgusclark jessgusclark merged commit 3f8a5d2 into develop Feb 9, 2024
1 check passed
@jessgusclark jessgusclark deleted the sigle-chainId branch February 9, 2024 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants