Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/BEV-2131 Will now select medium fee rate or blockbook recomme… #879

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

Freshenext
Copy link
Collaborator

@Freshenext Freshenext commented Feb 1, 2024

…nded fee when sending bitcoin.

How to test:
1-Go to send screen
2-Send bitcoin
3-Input address
4-Input amount
5-Click on send
6-The mining fee input should update and be adjusted with the medium rate that you see in that component.

@Freshenext Freshenext self-assigned this Feb 1, 2024
@Freshenext Freshenext marked this pull request as ready for review February 5, 2024 14:25
@Freshenext Freshenext force-pushed the US-2131 branch 3 times, most recently from 1d59a56 to 98e8777 Compare February 6, 2024 01:56
Copy link
Member

@jessgusclark jessgusclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rebase this and check it? I'm getting a NaN.toString() error.

Copy link
Contributor

@jormelCoin jormelCoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got this error message:

20240209_102715.mp4

@Freshenext
Copy link
Collaborator Author

Guys remember there is/was a PR that fixed that error: #893

We had to wait until that PR was merged to test this again.

@jormelCoin @jessgusclark you may go ahead and test again

@jormelCoin jormelCoin added the Tested Ready to move forward label Feb 12, 2024
Copy link
Member

@jessgusclark jessgusclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I didn't realize the error was blocking this one.

@jessgusclark jessgusclark merged commit cb4ce10 into develop Feb 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tested Ready to move forward
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants