US-1739: Offline Screen #669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
rodrigoncalves
commented
Jul 5, 2023
•
rodrigoncalves
commented
rodrigoncalves
force-pushed
the
us-1739
branch
3 times, most recently
from
4c9de2a
to
28a1989
Compare
jessgusclark
requested changes
Jul 16, 2023
There was a problem hiding this comment.
I tested this out with a simulator and when I turned off the computer's internet, and reloaded at app, it reset and took me back to the init screen.
Questions:
- What is the executed outcome here, and does it only happen on the initial load, or will it happen if the device looses internet while the app is one?
For this PR, it just checks internet connection on the initial load. If user looses connection during the usage, he should be able to use the app normally but in a view-only state. He can't do a transaction, for example. We should address this in the future. Regarding the issue you found, I made a fix for it. Please test it again. |
jessgusclark
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.