Refactor features with terms and conditions #303
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ronaldsg20
commented
Aug 30, 2024
ronaldsg20
commented
I've updated the features controller creating a new dataservice for the terms collections in order to retrieve the user only the enabled terms and conditions version available.
lserra-iov
reviewed
Sep 5, 2024
| let responseCode = this.HTTP_ERROR; | ||
| try { | ||
| retorno = await this.featuresDatService.getAll(); | ||
| features = await this.featuresDatService.getAll(); | ||
| const termsIdx = features.findIndex((feature) => feature.name === 'terms_and_conditions'); |
There was a problem hiding this comment.
What if there is no terms_and_conditions flag? Or more than one but the first "found" disabled?
lserra-iov
approved these changes
Sep 20, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ronaldsg20
force-pushed
the
refactor/ff-terms-and-conditions
branch
from
7898a17
to
1678071
Compare
ronaldsg20
force-pushed
the
refactor/ff-terms-and-conditions
branch
from
1678071
to
b97b783
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.