Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for linux/openat2.h availability #3657

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Check for linux/openat2.h availability #3657

merged 1 commit into from
Nov 30, 2023

Conversation

multun
Copy link
Contributor

@multun multun commented Nov 27, 2023 •
edited
Loading

Fixes #3655

@multun multun mentioned this pull request Nov 27, 2023
Closed
@rocallahan
Copy link
Collaborator

Thanks for the reminder!

@rocallahan
Copy link
Collaborator

I actually think a better fix here is to not include openat2.h and instead just define the needed constants in test/util.h. That lets the test run on more systems. That's what we do for other new constants.

@multun
Copy link
Contributor Author

multun commented Nov 30, 2023

Alright, I'll do that

@multun multun force-pushed the fix-openat2-unavailable branch from 45ea853 to e7ff357 Compare November 30, 2023 09:03
@rocallahan rocallahan merged commit aa2ef05 into rr-debugger:master Nov 30, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fatal error: linux/openat2.h: No such file or directory
2 participants
@multun @rocallahan