-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove unused dependencies & add GHA flow #429
Conversation
7693758
to
d18b01c
Compare
Either way, it make the checks much much longer, so I'm not sure it's entirely worth it to have it as workflow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Glad to drop all the unused deps.
Looks like all the extra time is just building cargo-udeps.
I couldn't manage to get toolchain caching working correctly, but it should be possible to do this once and cache it for subsequent runs...
Seems like the |
Ah. Maybe using a prebuilt version instead? There are binary releases on github (need to untar them though). |
takes 1.5 seconds on my machine.
|
d18b01c
to
9757d62
Compare
f94b267
to
ce6d0e9
Compare
I found https://github.com/aig787/cargo-udeps-action :D seems to work as expected |
Should it be made part of the existing jobs or parallel ones?