Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable Gravatar Style #215

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

muhqu
Copy link

@muhqu muhqu commented Jul 5, 2013

Added a ComboBox to let users choose another Gravatar Style.

gitx

@rowanj
Copy link
Owner

rowanj commented Jul 8, 2013

Nice change, I did think the default was a bit arbitrary.

On a side note, do you think it'd be good to add a mini gravatar to the author column?

@muhqu
Copy link
Author

muhqu commented Jul 8, 2013

Thanks!

A 16x16 gravatar in the Log View? I think that would be too much.

Just noticed that my pull request collides with #213. My changes to the Preferences.xib are minor, just a combo box which binds its value to PBGavatarStyle user setting. So I'm happy to rebase, if you want to merge #213 first.

@rowanj
Copy link
Owner

rowanj commented Jul 8, 2013

Thanks for the description, I should be able to handle the merge when I hit it.

@5sw
Copy link

5sw commented Oct 30, 2013

Are there any user-defined gravatar styles or is the list from your screen shot fixed? If the list is fixed a popup button would be better suited than a combo box.

@muhqu
Copy link
Author

muhqu commented Oct 31, 2013

@5sw the list of supported gravatar styles depends on what gravatar.com offers... see: http://en.gravatar.com/site/implement/images/ ...while the set of gravatar styles has not changed for quiet a long time, it's quiet possible that they might come up with new styles.

I've chosen a combobox as it allows the user to specify exactly which style they want. So when gravatar.com might come up with a new style, there would be no need to update GitX to let users use it. Quiet hypothetical, but that's why I've used a combobox...

ssp pushed a commit to ssp/gitx that referenced this pull request May 23, 2021
More modern Syntaxhighlighter submodule
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants