Added memoization for url parser

routejs · Mar 16, 2023 · aef3cb6 · aef3cb6
1 parent a9aa85a
commit aef3cb6
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 5 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@routejs/router",
-  "version": "2.1.3",
+  "version": "2.1.4",
   "description": "Fast and lightweight http routing engine for nodejs",
   "main": "index.mjs",
   "type": "module",

diff --git a/src/router.cjs b/src/router.cjs
@@ -9,6 +9,7 @@ module.exports = class Router {
     host: undefined,
   };
   #route = null;
+  #cache = {};
 
   constructor(options = {}) {
     if (options.caseSensitive === true) {
@@ -277,8 +278,15 @@ module.exports = class Router {
   }
 
   handle({ requestHost, requestMethod, requestUrl, request, response }) {
-    const parsedUrl = url.parse(requestUrl ? requestUrl : "");
-    const requestPath = decodeURIComponent(parsedUrl.pathname);
+    let requestPath;
+    if (this.#cache.hasOwnProperty(requestUrl)) {
+      requestPath = this.#cache[requestUrl];
+    } else {
+      const parsedUrl = url.parse(requestUrl ? requestUrl : "");
+      this.#cache[requestUrl] = decodeURI(parsedUrl.pathname);
+      requestPath = this.#cache[requestUrl];
+    }
+
     const callStack = {
       stack: this.routes(),
       index: 0,

diff --git a/src/router.mjs b/src/router.mjs
@@ -9,6 +9,7 @@ export default class Router {
     host: undefined,
   };
   #route = null;
+  #cache = {};
 
   constructor(options = {}) {
     if (options.caseSensitive === true) {
@@ -277,8 +278,15 @@ export default class Router {
   }
 
   handle({ requestHost, requestMethod, requestUrl, request, response }) {
-    const parsedUrl = url.parse(requestUrl ? requestUrl : "");
-    const requestPath = decodeURIComponent(parsedUrl.pathname);
+    let requestPath;
+    if (this.#cache.hasOwnProperty(requestUrl)) {
+      requestPath = this.#cache[requestUrl];
+    } else {
+      const parsedUrl = url.parse(requestUrl ? requestUrl : "");
+      this.#cache[requestUrl] = decodeURI(parsedUrl.pathname);
+      requestPath = this.#cache[requestUrl];
+    }
+
     const callStack = {
       stack: this.routes(),
       index: 0,