Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix seg.Remove Swallowing Error #38

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Conversation

ghosx
Copy link
Contributor

@ghosx ghosx commented Jun 17, 2024

// Remove removes the segment file.
func (seg *segment) Remove() error {
	if !seg.closed {
		seg.closed = true
		if err := seg.fd.Close(); err != nil {
			return err
		}
	}

	return os.Remove(seg.fd.Name())
}

@roseduan roseduan merged commit cce2a07 into rosedblabs:main Jun 18, 2024
2 checks passed
@ghosx ghosx deleted the fix/swalloederror branch June 24, 2024 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants