no need to return err in pendingWrites

benchmark/bench_test.go

@@ -51,11 +51,9 @@ func BenchmarkWAL_WriteBatch(b *testing.B) {
 	b.ReportAllocs()
 	for i := 0; i < b.N; i++ {
 		for j := 0; j < 31; j++ {
-			err := walFile.PendingWrites([]byte(strings.Repeat("X", wal.MB)))
-			assert.Nil(b, err)
+			walFile.PendingWrites([]byte(strings.Repeat("X", wal.MB)))
 		}
-		err := walFile.PendingWrites([]byte(strings.Repeat("X", wal.MB)))
-		assert.Equal(b, wal.ErrPendingSizeTooLarge, err)
+		walFile.PendingWrites([]byte(strings.Repeat("X", wal.MB)))
 		pos, err := walFile.WriteAll()
 		assert.Nil(b, err)
 		assert.Equal(b, 0, len(pos))

wal.go

@@ -315,14 +315,13 @@ func (wal *WAL) ClearPendingWrites() {
 // PendingWrites add data to wal.pendingWrites and wait for batch write.
 // If the data in pendingWrites exceeds the size of one segment,
 // it will return a 'ErrPendingSizeTooLarge' error and clear the pendingWrites.
-func (wal *WAL) PendingWrites(data []byte) error {
+func (wal *WAL) PendingWrites(data []byte) {
 	wal.pendingWritesLock.Lock()
 	defer wal.pendingWritesLock.Unlock()
 
 	size := wal.maxDataWriteSize(int64(len(data)))
 	wal.pendingSize += size
 	wal.pendingWrites = append(wal.pendingWrites, data)
-	return nil
 }
 
 // rotateActiveSegment create a new segment file and replace the activeSegment.

wal_test.go

@@ -190,8 +190,7 @@ func TestWAL_Reader(t *testing.T) {
 func testWriteAllIterate(t *testing.T, wal *WAL, size, valueSize int) {
 	for i := 0; i < size; i++ {
 		val := strings.Repeat("wal", valueSize)
-		err := wal.PendingWrites([]byte(val))
-		assert.Nil(t, err)
+		wal.PendingWrites([]byte(val))
 	}
 	positions, err := wal.WriteAll()
 	assert.Nil(t, err)