-
Notifications
You must be signed in to change notification settings - Fork 637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] add auto merge background task #298
[Feature] add auto merge background task #298
Conversation
Hi @roseduan, please take a look. Thanks. 😊 I have one problem when writing unit test for auto merge. I don't know how to check whether merge action has been operated without an internal flag. I think I should add such a unit test for case coverage. Best Regards |
Thanks for your PR. Merge operation will discard all invalid data, and rewrite all valid data into new data files. |
Hi @roseduan , thanks very much for your warm suggestion. I'm sorry for lack of explanation for 'internal flag'. Previously I wanted to add a flag for merge actions and write unit test with it. But it makes no sense for production code. I'll use keys' total count for unit test. Happy New Year! 🎉 Best Regards |
Hi @roseduan , please take a look. I have use datafile's key total count to make unit test. It works now! Thanks very much for your suggestion. |
Hi @roseduan , sorry for forgot adding cleanup code for my unit tests. I have ran this commit in my own repo's GitHub Actions. Please take a look. Thanks very much, |
Thanks for your great work, looking forward to your next PR! |
Thanks for your warm help. I'm satisfied to make some contribution. 😊 Best Regards |
Issue
#297
We need to add an auto merge background task with cron expression scheduler.
Proposed Changes