Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip add governance template #135

Draft
wants to merge 1 commit into
base: rolling
Choose a base branch
from

Conversation

mikaelarguedas
Copy link
Member

Opening this for visibility, PoC for #130.
Will wait for the ongoing API changes to settle before deconflicting and iterating.

What's in this PR:

  • New governance.xsl template to generate the governance files
  • Modifies the policy format to take a new protection attribute
  • change create_signed_governance_file argument order to match the ones from create_signed_permission_file
  • removes creation of a keystore-wide governance file and generate one per key

Open ended questions:

  • What is the best default behavior ? encrypting all data unless specified otherwise?
  • Should the new attribute be required or optional ? (if optional use the default from previous bullet)

Still todo:

  • cleanup code and refactor to avoid duplication
  • settle on behavior in case of multiple policies to process

Signed-off-by: Mikael Arguedas <[email protected]>
@audrow audrow changed the base branch from master to rolling June 28, 2022 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant