Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Tinymovr motor controller #282

Merged
merged 9 commits into from
Jan 4, 2024
Merged

Add Tinymovr motor controller #282

merged 9 commits into from
Jan 4, 2024

Conversation

yconst
Copy link
Contributor

@yconst yconst commented Oct 19, 2023

No description provided.

@yconst yconst requested a review from tfoote as a code owner October 19, 2023 12:24
tfoote
tfoote approved these changes Oct 27, 2023
View reviewed changes
Copy link
Member

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the addition. It looks good to me in the preview.

@tfoote
Copy link
Member

tfoote commented Oct 30, 2023

Sorry CI is failing with the new python version, can you please rebase on top of #284 ?

@yconst
Copy link
Contributor Author

yconst commented Nov 11, 2023

I updated the branch

@yconst
Copy link
Contributor Author

yconst commented Dec 4, 2023

Is there some update on this?

tfoote
tfoote approved these changes Jan 4, 2024
View reviewed changes
Copy link
Member

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why CI didn't automatically rerun. So I just checked it manually by hand.

@tfoote tfoote merged commit 8328e61 into ros-infrastructure:gh-pages Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tfoote tfoote tfoote approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yconst @tfoote