Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azimuth_diff if statement for vls128 in raw_data.cc seems wrong #527

Open
keenan-burnett opened this issue Jul 12, 2023 · 0 comments
Open
Labels

Comments

@keenan-burnett
Copy link

  • OS and Version: Ubuntu 16.04
  • ROS Version: Kinetic
  • Built from Source or Downloaded from Official Repository: built from source
  • Version: commit hash: 29abd0e

Description
This if statement doesn't seem correct:

azimuth_diff = (block == BLOCKS_PER_PACKET - (4*dual_return)-1) ? 0 : last_azimuth_diff;

For the last block, we don't want to set the azimuth_diff to zero.

Perhaps the statement needs to be changed to:

azimuth_diff = (block == BLOCKS_PER_PACKET - (4*dual_return)-1) ? last_azimuth_diff : 0; 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant