Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new status information #109

Open
wants to merge 6 commits into
base: ros2-devel
Choose a base branch
from

Conversation

splatter96
Copy link

This MR adds the ability to output the current warning and OSSD states the scanner calculates and transmits as part of the AR00 message. This is necessary to be able to use the scanner for any safety setup.

This MR relies on ros-drivers/urg_node_msgs#6 to be merged first.

@mikeferguson mikeferguson self-assigned this May 25, 2023
@splatter96
Copy link
Author

The checks curently fail, because the needed changes for the urg_node_msgs package are not yet in the official repos, which the jenkins bot relies on? Is there any way to use the current github master of that repo for the jenkins checks?

@mikeferguson
Copy link
Member

Still working towards a release of the update to messages - we shouldn't change the message in released distros (Humble/Iron) so I needed up branch off for a rolling release. Still waiting for that PR to be merged in rosdistro, and then I will do a new message package release.

@mikeferguson
Copy link
Member

ros/rosdistro#37629 is the release for urg_node_msgs - now we have to wait for that to be merged, built and synced, and then this should pass.

@splatter96
Copy link
Author

I pushed an empty commit to retrigger the actions and seems there are atleast no errors in those. Can you have a look if it is possible to merge this @mikeferguson ?

@splatter96
Copy link
Author

@mikeferguson did you have time to check the MR in the meantime? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants